no_rbind_devtmpfs : lp:~gjolly/livecd-rootfs : Git : Code : livecd-rootfs

Get this branch:: git clone -b no_rbind_devtmpfs https://git.launchpad.net/~gjolly/livecd-rootfs

Only Gauthier Jolly can upload to this branch. If you are Gauthier Jolly please log in for upload directions.

Branch merges

On hold for merging into livecd-rootfs:ubuntu/master

Dimitri John Ledkov: Approve on 2021-05-05

Branch information

Name:: no_rbind_devtmpfs

Repository:: lp:~gjolly/livecd-rootfs

Recent commits

0584a54... by Gauthier Jolly on 2021-02-22

setup_mountpoint: rename devtmpfs filesystem for consistency

bf52e6d... by Gauthier Jolly on 2021-02-22

mount a fresh devmpfs filesystem instead of rbind host /dev

Because -rbind is used to mount `chroot/dev`, the host machine gets
impacted by the build process. Indeed, every mount/unmount of anything
under `chroot/dev` would also unmount the devices from the host system.

Also this makes the build fails in case any `/dev/pts` device is opened
(eg ssh connection or any terminal open).

This patch addresses this issue by mounting a fresh devtmpfs on
`chroot/dev` instead of using the host's one.

8745460... by Dimitri John Ledkov on 2021-02-05

releasing package livecd-rootfs version 2.711

82aca61... by Dimitri John Ledkov on 2021-02-05

Merge remote-tracking branch 'xnox/fix-misisng-systemd-detect-virt' into ubuntu/master

72f2647... by Dimitri John Ledkov on 2021-02-05

Merge remote-tracking branch 'xnox/fsck-all-the-things' into ubuntu/master

096a00f... by Dimitri John Ledkov on 2021-02-03

functions: stop removing systemd-detect-virt unconditionally in undivert_grub

One can call divert_grub; replace_kernel; undivert_grub. And
replace_kernel will call into force_boot_without_initramfs, which
under certain conditions can call divert_grub &
undivert_grub. Resulting in undivert_grub called twice in a row.

When undivert_grub is called twice in a row it wipes
systemd-detect-virt binary from disk, as the rm call is unguarded to
check that there is something to divert if systemd package is
installed. And if the systemd package is not installed, it does not
check that systemd-detect-virt file is in-fact what divert_grub has
created.

Add a guard to check that systemd-detect-virt is the placeholder one,
before removing it.

LP: #1902260

33b7272... by Dimitri John Ledkov on 2021-02-01