Merge lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/ubuntu-it-ask into lp:ubuntu-it-ask

Proposed by Giuseppe Terrasi
Status: Merged
Merged at revision: 27
Proposed branch: lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/ubuntu-it-ask
Merge into: lp:ubuntu-it-ask
Diff against target: 114 lines (+36/-36)
3 files modified
forum/skins/light/templates/auth/signin.html (+2/-2)
forum_modules/openidauth/authentication.py (+33/-33)
settings_local.py (+1/-1)
To merge this branch: bzr merge lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/ubuntu-it-ask
Reviewer Review Type Date Requested Status
Giuseppe Terrasi (community) Approve
Riccardo Padovani Approve
Review via email: mp+113290@code.launchpad.net

Description of the change

Unica differenza: ho lasciato yahoo come scriveva WebbIT...

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

No Twitter? Non so, la mia è solo una proposta, è che c'è una buona comunità anche su Twitter!

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

Si. twitter e' in elenco e disponibile, ma non configurato, sul sito di prova.

Facendo parte del modulo authauth non e' stato mo dificato e quindi non e' visibile in questo merge che vaa a modificare solo openidauth.

Ricapitolando: fb, twitter, google, yahoo lp e ubuntu SSO

Revision history for this message
Riccardo Padovani (rpadovani) :
review: Approve
23. By root <email address hidden>

1) sync with trunk
2) disable oauthauth (twitter) and facebookauth openID authentication

24. By root <email address hidden>

close a tag

25. By Giuseppe Terrasi

corretto altro errore di distrazione...

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

Sono riuscito a sistemare il tutto. C'erano degli errori... di distrazione.
Scollegandovi e facendo clic su accedi potete vedere il risultato.

review: Needs Resubmitting
Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

Provato per alcuni giorni sembra non dare noie. Importo nel trunk principale.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'forum/skins/light/media/images/openid/launchpad.png'
2Binary files forum/skins/light/media/images/openid/launchpad.png 1970-01-01 00:00:00 +0000 and forum/skins/light/media/images/openid/launchpad.png 2012-07-05 20:47:19 +0000 differ
3=== added file 'forum/skins/light/media/images/openid/ubuntusso.png'
4Binary files forum/skins/light/media/images/openid/ubuntusso.png 1970-01-01 00:00:00 +0000 and forum/skins/light/media/images/openid/ubuntusso.png 2012-07-05 20:47:19 +0000 differ
5=== modified file 'forum/skins/light/templates/auth/signin.html'
6--- forum/skins/light/templates/auth/signin.html 2012-07-02 19:36:31 +0000
7+++ forum/skins/light/templates/auth/signin.html 2012-07-05 20:47:19 +0000
8@@ -99,13 +99,13 @@
9 <input type="hidden" class="validate_email" name="validate_email" value="yes" />
10 </form>
11 {% endfor %}
12- <h3 class="or_label">{% trans 'Or...' %}</h3>
13+ <!-- <h3 class="or_label">{% trans 'Or...' %}</h3>
14 <form name="signin_form" id="dummy_form_unused" class="signin_form" method="POST" action="">
15 {% csrf_token %}
16 <fieldset>
17 {% trans 'Click' %} <a href="{% url auth_request_tempsignin %}">{% trans 'here' %}</a> {% trans "if you're having trouble signing in." %}
18 </fieldset>
19- </form>
20+ </form> -->
21 <script type="text/html" id="simple_form_template">
22 <fieldset id="slot_form">
23 <p id="provider_name_slot">{% trans 'Enter your ' %}%%YOUR_WHAT%%</p>
24
25=== modified file 'forum_modules/openidauth/authentication.py'
26--- forum_modules/openidauth/authentication.py 2012-07-05 20:29:16 +0000
27+++ forum_modules/openidauth/authentication.py 2012-07-05 20:47:19 +0000
28@@ -12,16 +12,38 @@
29 human_name = 'Google'
30 icon = '/media/images/openid/google.gif'
31
32-#class YahooAuthConsumer(OpenIdAbstractAuthConsumer):
33-# def get_user_url(self, request):
34-# return 'http://yahoo.com/'
35-
36-#class YahooAuthContext(ConsumerTemplateContext):
37-# mode = 'BIGICON'
38-# type = 'DIRECT'
39-# weight = 300
40-# human_name = 'Yahoo'
41-# icon = '/media/images/openid/yahoo.gif'
42+class YahooAuthConsumer(OpenIdAbstractAuthConsumer):
43+ def get_user_url(self, request):
44+ return 'http://yahoo.com/'
45+
46+class YahooAuthContext(ConsumerTemplateContext):
47+ mode = 'BIGICON'
48+ type = 'DIRECT'
49+ weight = 300
50+ human_name = 'Yahoo'
51+ icon = '/media/images/openid/yahoo.gif'
52+
53+class LaunchpadAuthConsumer(OpenIdAbstractAuthConsumer):
54+ def get_user_url(self, request):
55+ return 'https://login.launchpad.net'
56+
57+class LaunchpadAuthContext(ConsumerTemplateContext):
58+ mode = 'BIGICON'
59+ type = 'DIRECT'
60+ weight = 200
61+ human_name = 'Launchpad OpenID'
62+ icon = '/media/images/openid/launchpad.png'
63+
64+class UbuntuSSOAuthConsumer(OpenIdAbstractAuthConsumer):
65+ def get_user_url(self, request):
66+ return 'https://login.ubuntu.com'
67+
68+class UbuntuSSOAuthContext(ConsumerTemplateContext):
69+ mode = 'BIGICON'
70+ type = 'DIRECT'
71+ weight = 200
72+ human_name = 'Ubuntu Single Sign On'
73+ icon = '/media/images/openid/ubuntusso.png'
74
75 #class AolAuthConsumer(OpenIdAbstractAuthConsumer):
76 # def get_user_url(self, request):
77@@ -179,26 +201,4 @@
78 # weight = 300
79 # human_name = 'OpenId url'
80 # stack_item_template = 'modules/openidauth/openidurl.html'
81-# icon = '/media/images/openid/openid-inputicon.gif'
82-
83-class LaunchpadAuthConsumer(OpenIdAbstractAuthConsumer):
84- def get_user_url(self, request):
85- return 'https://login.launchpad.net'
86-
87-class LaunchpadAuthContext(ConsumerTemplateContext):
88- mode = 'BIGICON'
89- type = 'DIRECT'
90- weight = 200
91- human_name = 'Launchpad OpenID'
92- icon = '/media/images/openid/launchpad.gif'
93-
94-class UbuntuSSOAuthConsumer(OpenIdAbstractAuthConsumer):
95- def get_user_url(self, request):
96- return 'https://login.ubuntu.com'
97-
98-class UbuntuSSOAuthContext(ConsumerTemplateContext):
99- mode = 'BIGICON'
100- type = 'DIRECT'
101- weight = 200
102- human_name = 'Ubuntu Single Sign On'
103- icon = '/media/images/openid/ubuntusso.gif'
104+# icon = '/media/images/openid/openid-inputicon.gif''
105
106=== modified file 'settings_local.py'
107--- settings_local.py 2012-07-02 19:39:03 +0000
108+++ settings_local.py 2012-07-05 20:47:19 +0000
109@@ -60,4 +60,4 @@
110 OSQA_DEFAULT_SKIN = 'default'
111
112 # disable mysqlfulltxt and local authentication (registrations users)
113-DISABLED_MODULES = ['books', 'recaptcha', 'project_badges', 'mysqlfulltxt', 'localauth']
114+DISABLED_MODULES = ['books', 'recaptcha', 'project_badges', 'mysqlfulltxt', 'localauth', 'oauthauth', 'facebookauth']

Subscribers

People subscribed via source and target branches

to all changes: