Merge lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/sync-with-upstream into lp:~ubuntu-it-ask/ubuntu-it-ask/dev

Proposed by Giuseppe Terrasi
Status: Merged
Merged at revision: 66
Proposed branch: lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/sync-with-upstream
Merge into: lp:~ubuntu-it-ask/ubuntu-it-ask/dev
Diff against target: 96 lines (+26/-11)
4 files modified
forum/skins/default/media/js/wmd/showdown.js (+4/-1)
forum/skins/default/media/js/wmd/wmd.js (+6/-1)
forum/templatetags/email_tags.py (+1/-1)
forum/utils/mail.py (+15/-8)
To merge this branch: bzr merge lp:~giuseppeterrasi-deactivatedaccount/ubuntu-it-ask/sync-with-upstream
Reviewer Review Type Date Requested Status
Giuseppe Terrasi (community) Approve
Review via email: mp+120265@code.launchpad.net

Description of the change

Questo branch porta la nostra versione dalla revisione 1273 alla revisione 1277 upstream.

Richiede però altri test. Sarebbe utile che anche altri lo provassero.

L'elenco dei cambiamenti è sul sito di prova.

To post a comment you must log in.
67. By Giuseppe Terrasi <email address hidden>

sync with dev

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'forum/skins/default/media/js/wmd/showdown.js'
2--- forum/skins/default/media/js/wmd/showdown.js 2012-06-22 20:37:14 +0000
3+++ forum/skins/default/media/js/wmd/showdown.js 2012-09-22 14:05:22 +0000
4@@ -167,6 +167,9 @@
5 // attacklab: Restore tildes
6 text = text.replace(/~T/g,"~");
7
8+ text = text.replace(/&amp;lt;/g,"<");
9+ text = text.replace(/&amp;gt;/g,">");
10+
11 return text;
12 }
13
14@@ -1328,4 +1331,4 @@
15 // If anyone's interested, tell the world that this file's been loaded
16 if (Attacklab.fileLoaded) {
17 Attacklab.fileLoaded("showdown.js");
18-}
19\ No newline at end of file
20+}
21
22=== modified file 'forum/skins/default/media/js/wmd/wmd.js'
23--- forum/skins/default/media/js/wmd/wmd.js 2012-07-08 10:55:03 +0000
24+++ forum/skins/default/media/js/wmd/wmd.js 2012-09-22 14:05:22 +0000
25@@ -28,7 +28,12 @@
26 if(error != ''){
27 alert(error);
28 }else{
29- imageUrl.attr('value', appUrl + fileURL);
30+ if(fileURL == ''){
31+ alert("There was an internal server error uploading your file.\nPermission denied.");
32+ }
33+ else{
34+ imageUrl.attr('value', appUrl + fileURL);
35+ }
36 }
37
38 },
39
40=== modified file 'forum/templatetags/email_tags.py'
41--- forum/templatetags/email_tags.py 2012-06-22 20:37:14 +0000
42+++ forum/templatetags/email_tags.py 2012-09-22 14:05:22 +0000
43@@ -20,7 +20,7 @@
44 self.nodelist.render(context)
45 messages.append((recipient, context['subject'], context['htmlcontent'], context['textcontent'], context['embeddedmedia']))
46
47- create_and_send_mail_messages(messages)
48+ create_and_send_mail_messages(messages, sender_data=context['sender'], reply_to=context['reply_to'])
49
50 @register.tag
51 def email(parser, token):
52
53=== modified file 'forum/utils/mail.py'
54--- forum/utils/mail.py 2012-06-22 20:37:14 +0000
55+++ forum/utils/mail.py 2012-09-22 14:05:22 +0000
56@@ -24,9 +24,9 @@
57 from forum.utils.html2text import HTML2Text
58 from threading import Thread
59
60-def send_template_email(recipients, template, context):
61+def send_template_email(recipients, template, context, sender=None, reply_to = None):
62 t = loader.get_template(template)
63- context.update(dict(recipients=recipients, settings=settings))
64+ context.update(dict(recipients=recipients, settings=settings, sender=sender, reply_to=reply_to))
65 t.render(Context(context))
66
67 def create_connection():
68@@ -44,16 +44,23 @@
69 return connection
70
71
72-def create_and_send_mail_messages(messages):
73+def create_and_send_mail_messages(messages, sender_data=None, reply_to=None):
74 if not settings.EMAIL_HOST:
75 return
76
77 sender = Header(unicode(settings.APP_SHORT_NAME), 'utf-8')
78- sender.append('<%s>' % unicode(settings.DEFAULT_FROM_EMAIL))
79- sender = u'%s <%s>' % (unicode(settings.APP_SHORT_NAME), unicode(settings.DEFAULT_FROM_EMAIL))
80-
81- reply_to = unicode(settings.DEFAULT_REPLY_TO_EMAIL)
82-
83+
84+ if sender_data == None:
85+ sender.append('<%s>' % unicode(settings.DEFAULT_FROM_EMAIL))
86+ sender = u'%s <%s>' % (unicode(settings.APP_SHORT_NAME), unicode(settings.DEFAULT_FROM_EMAIL))
87+ else:
88+ sender.append('<%s>' % unicode(sender_data['email']))
89+ sender = u'%s <%s>' % (unicode(sender_data['name']), unicode(sender_data['email']))
90+
91+ if reply_to == None:
92+ reply_to = unicode(settings.DEFAULT_REPLY_TO_EMAIL)
93+ else:
94+ reply_to = unicode(reply_to)
95 try:
96 connection = None
97

Subscribers

No one subscribed via source and target branches