Merge lp:~giuseppeterrasi-deactivatedaccount/serverguide/serverguide-review-12-3 into lp:~ubuntu-core-doc/serverguide/precise

Proposed by Giuseppe Terrasi
Status: Merged
Approved by: Peter Matulis
Approved revision: 40
Merged at revision: 53
Proposed branch: lp:~giuseppeterrasi-deactivatedaccount/serverguide/serverguide-review-12-3
Merge into: lp:~ubuntu-core-doc/serverguide/precise
Diff against target: 21 lines (+2/-2)
1 file modified
serverguide/C/lamp-applications.xml (+2/-2)
To merge this branch: bzr merge lp:~giuseppeterrasi-deactivatedaccount/serverguide/serverguide-review-12-3
Reviewer Review Type Date Requested Status
Doug Smythies Approve
Peter Matulis Needs Fixing
Review via email: mp+96772@code.launchpad.net

Description of the change

Reviewing sub-chapter 12.3:
- istruction/path/url: ok
- specified that memory limit is disable by default (then suggest an example size)

To post a comment you must log in.
Revision history for this message
Peter Matulis (petermatulis) wrote :

Should

(disable by default)

be

(disabled by default)

?

review: Needs Fixing
40. By Giuseppe Terrasi

typo

Revision history for this message
Giuseppe Terrasi (giuseppeterrasi-deactivatedaccount) wrote :

uhg... sorry :-)
fixed :-)

Revision history for this message
Doug Smythies (dsmythies) wrote :

This is O.K. and should be approved.

As a side note, please know that both the resulting HTML and PDF have double spaces taken out.

review: Approve
Revision history for this message
Peter Matulis (petermatulis) wrote :

Thank you Doug. Dealing with this one now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'serverguide/C/lamp-applications.xml'
2--- serverguide/C/lamp-applications.xml 2012-03-09 12:55:08 +0000
3+++ serverguide/C/lamp-applications.xml 2012-03-09 20:16:18 +0000
4@@ -277,7 +277,7 @@
5 Before installing <application>MediaWiki</application> you should also install
6 <application>Apache2</application>, the <application>PHP5</application> scripting language
7 and Database a Management System. <application>MySQL</application> or <application>PostgreSQL</application>
8- are the most common, choose one depending on your need. Please refer to those
9+ are the most common, choose one depending on your need. Please refer to those
10 sections in this manual for installation instructions.
11 </para>
12
13@@ -341,7 +341,7 @@
14
15 <para>
16 You may also want to edit <filename>/etc/mediawiki/LocalSettings.php</filename>
17- adjusting:
18+ in order to set the memory limit (disabled by default):
19 </para>
20
21 <programlisting>

Subscribers

People subscribed via source and target branches