Merge lp:~gilir/synapse-project/packaging into lp:synapse-project

Proposed by Julien Lavergne
Status: Merged
Merged at revision: 229
Proposed branch: lp:~gilir/synapse-project/packaging
Merge into: lp:synapse-project
Diff against target: 201 lines (+118/-21)
6 files modified
debian/changelog (+21/-2)
debian/control (+15/-10)
debian/copyright (+75/-8)
debian/docs (+4/-0)
debian/rules (+1/-1)
debian/watch (+2/-0)
To merge this branch: bzr merge lp:~gilir/synapse-project/packaging
Reviewer Review Type Date Requested Status
Michal Hruby Approve
Review via email: mp+42779@code.launchpad.net

This proposal supersedes a proposal from 2010-12-04.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

Could you please fix the conflict in po/* (probably by reverting anything you inadvertently changed there). Also I added optional dependency on app-indicator, could you add that?

review: Needs Fixing
Revision history for this message
Julien Lavergne (gilir) wrote : Posted in a previous version of this proposal

Re-merge with upstream.
Build-depends on libappindicator adding. Flag to configure set to --auto, so it should handle the case when libappindicator is too old.

Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

@gilir: I committed proper licenses to the files, could you update the branch please?

review: Needs Fixing
Revision history for this message
Julien Lavergne (gilir) wrote : Posted in a previous version of this proposal

The commit said : Use proper licenses - LGPL2.1+ for core, GPL3 for UI

But the output of licensecheck is quite different :

src/synapse-main.vala: LGPL (v3 or later)
src/ui-cmd-line.vala: GPL (v2 or later)
src/ui-basic-gtk.vala: GPL (v2 or later)
src/tile-view/wrap-label.vala: GPL (v2 or later)
src/tile-view/abstract-tile-object.vala: GPL (v2 or later)
src/tile-view/tile.vala: GPL (v2 or later)
src/tile-view/tile-view.vala: GPL (v2 or later)
src/plugins/locate-plugin.vala: GPL (v2 or later)
src/plugins/desktop-file-plugin.vala: GPL (v2 or later)
src/plugins/gnome-session-plugin.vala: GPL (v2 or later)
src/plugins/test-slow-plugin.vala: GPL (v2 or later)
src/plugins/command-plugin.vala: GPL (v2 or later)
src/plugins/upower-plugin.vala: GPL (v2 or later)
src/plugins/rhythmbox-plugin.vala: GPL (v2 or later)
src/plugins/zeitgeist-plugin.vala: GPL (v2 or later)
src/plugins/devhelp-search.vala: GPL (v2 or later)
src/plugins/directory-plugin.vala: GPL (v2 or later)
src/plugins/hybrid-search-plugin.vala: GPL (v2 or later)
src/plugins/dictionary.vala: GPL (v2 or later)
src/plugins/gnome-screensaver-plugin.vala: GPL (v2 or later)
src/plugins/banshee-plugin.vala: GPL (v2 or later)
src/ui-cairo-gtk-virgilio.vala: LGPL (v3 or later)
src/core/data-sink.vala: LGPL (v2.1 or later)
src/core/result-set.vala: LGPL (v2.1 or later)
src/core/query.vala: LGPL (v2.1 or later)
src/core/match.vala: LGPL (v2.1 or later)
src/core/config-service.vala: LGPL (v2 or later)
src/core/dbus-service.vala: LGPL (v2.1 or later)
src/core/plugin.vala: LGPL (v2.1 or later)
src/core/utils.vala: LGPL (v2.1 or later)
src/core/common-actions.vala: LGPL (v2.1 or later)
src/core/desktop-file-service.vala: LGPL (v2.1 or later)
src/ui-widgets.vala: LGPL (v3 or later)
src/ui-settings.vala: LGPL (v3 or later)
src/ui-cairo-gtk-mini.vala: LGPL (v3 or later)
src/ui-cairo-gtk-base.vala: LGPL (v3 or later)
src/ui-inspector.vala: LGPL (v3 or later)
src/ui-cairo-gtk-two-lines.vala: LGPL (v3 or later)
src/ui-cairo-gtk.vala: LGPL (v3 or later)
src/ui-interface.vala: LGPL (v3 or later)
src/ui-utils.vala: LGPL (v3 or later)

Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

Wow... I'm really unable to copy paste properly, I'll fix it in asap.

Revision history for this message
Michal Hruby (mhr3) wrote : Posted in a previous version of this proposal

Should be good now. I hope...

Revision history for this message
Julien Lavergne (gilir) wrote :

debian/copyright updated.

Revision history for this message
Michal Hruby (mhr3) wrote :

Looks good.

review: Approve
lp:~gilir/synapse-project/packaging updated
229. By Michal Hruby

Merge from <lp:~gilir/synapse-project/packaging>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-07 20:20:43 +0000
3+++ debian/changelog 2010-12-05 14:40:09 +0000
4@@ -1,5 +1,24 @@
5-synapse (0+bzr20101107-1) experimental; urgency=low
6+synapse (0.2.0+bzr-2) UNRELEASED; urgency=low
7+
8+ * debian/control:
9+ - Set zeitgeist and zeitgeist-fts-extension as Recommends.
10+ - Bump libgtk2.0-dev, libglib2.0-dev and intltool requierement.
11+ - Update Vcs-*.
12+ - Build-depends on pkg-config.
13+ - Build-depends on libappindicator-dev.
14+ * debian/docs:
15+ - Add upstream documentation.
16+ * debian/watch
17+ - Add a watch file.
18+ * debian/copyright
19+ - Update copyright holders and licenses.
20+ * debian/rules:
21+ - Pass --enable-indicator=auto to configure.
22+
23+ -- Julien Lavergne <gilir@ubuntu.com> Tue, 30 Nov 2010 21:55:53 +0100
24+
25+synapse (0.2.0+bzr-1) experimental; urgency=low
26
27 * Initial release.
28
29- -- Siegfried-Angel Gevatter Pujals <rainct@ubuntu.com> Fri, 10 Sep 2010 14:31:29 +0200
30+ -- Michal Hruby <michal.mhr@gmail.com> Fri, 10 Sep 2010 14:31:29 +0200
31
32=== modified file 'debian/control'
33--- debian/control 2010-12-01 12:25:25 +0000
34+++ debian/control 2010-12-05 14:40:09 +0000
35@@ -1,29 +1,34 @@
36 Source: synapse
37 Section: utils
38 Priority: optional
39-Maintainer: Siegfried-Angel Gevatter Pujals <rainct@ubuntu.com>
40+Maintainer: Michal Hruby <michal.mhr@gmail.com>
41 Build-Depends: debhelper (>= 7.0.50~),
42- intltool,
43+ intltool (>= 0.35),
44+ pkg-config,
45 valac (>= 0.9.7~),
46 libzeitgeist-dev,
47 libdbus-glib-1-dev,
48- libgtk2.0-dev,
49+ libgtk2.0-dev (>= 2.20.0),
50+ libglib2.0-dev (>= 2.22.0),
51 libgee-dev (>= 0.5.2),
52 libjson-glib-dev (>= 0.10.0),
53 libunique-dev,
54- libgtkhotkey-dev
55-Vcs-Bzr: bzr+ssh://bazaar.launchpad.net/~zeitgeist-packagers/sezen/debian-sezen2
56-Vcs-Browser: https://code.launchpad.net/~zeitgeist-packagers/sezen/debian-sezen2
57+ libgtkhotkey-dev,
58+ libappindicator-dev (>= 0.0.7)
59+Vcs-Bzr: http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/
60+Vcs-Browser: http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/files
61 Homepage: https://launchpad.net/synapse-project
62 Standards-Version: 3.9.1
63
64 Package: synapse
65 Architecture: any
66 Depends: ${shlibs:Depends},
67- ${misc:Depends},
68- zeitgeist (>= 0.5.0~) | zeitgeist-core (>= 0.5.0~),
69- libjson-glib-1.0-0 (>= 0.10.0),
70- libgee2 (>= 0.5.2)
71+ ${misc:Depends},
72+#Hard-code version for Lucid, ${shlibs:Depends} doesn't work for libs in the PPA
73+ libjson-glib-1.0-0 (>= 0.10.0),
74+ libgee2 (>= 0.5.2)
75+Recommends: zeitgeist (>= 0.5.0~) | zeitgeist-core (>= 0.5.0~),
76+ zeitgeist-fts-extension
77 Description: semantic file launcher
78 Synapse is a graphical launcher enabling you to start applications and also
79 to quickly find and access relevant documents and files (by making use of the
80
81=== modified file 'debian/copyright'
82--- debian/copyright 2010-11-07 20:20:43 +0000
83+++ debian/copyright 2010-12-05 14:40:09 +0000
84@@ -1,15 +1,82 @@
85-Format-Specification: http://dep.debian.net/deps/dep5/#index4h1
86+Format-Specification: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=59
87 Name: Synapse
88 Maintainer: Michal Hruby <michal.mhr@gmail.com>
89-Source: https://code.launchpad.net/sezen
90+Source: https://code.launchpad.net/synapse-project
91
92 Files: *
93-Copyright: © 2010, Michal Hruby <michal.mhr@gmail.com>
94+Copyright:
95+ 2010, Michal Hruby <michal.mhr@gmail.com>,
96+ 2006-2007-2008-2009 Andrea Cimitan
97+License: GPL-3+
98+
99+Files: src/core/*
100+Copyright:
101+ 2010, Michal Hruby <michal.mhr@gmail.com>,
102+License: LGPL-2.1+
103+
104+Files: src/plugins
105+ src/ui-cmd-line.vala
106+ src/ui-basic-gtk.vala
107+ src/tile-view/wrap-label.vala
108+ src/tile-view/abstract-tile-object.vala
109+ src/tile-view/tile.vala
110+ src/tile-view/tile-view.vala
111+Copyright:
112+ 2010, Michal Hruby <michal.mhr@gmail.com>,
113+ 2010, Igor S. Mandrigin <i@mandrigin.ru>
114 License: GPL-2+
115
116 Files: debian/*
117-Copyright: © 2010, Siegfried-Angel Gevatter Pujals <rainct@ubuntu.com>
118-License: GPL-2+
119-
120-License: GPL-2+
121- See `/usr/share/common-licenses/GPL'.
122+Copyright:
123+ 2010, Michal Hruby <michal.mhr@gmail.com>,
124+ 2010, Julien Lavergne <gilir@ubuntu.com>
125+License: GPL-3+
126+
127+License: GPL-3+
128+ This program is free software: you can redistribute it and/or modify
129+ it under the terms of the GNU General Public License as published by
130+ the Free Software Foundation, either version 3 of the License, or
131+ (at your option) any later version.
132+
133+ This program is distributed in the hope that it will be useful,
134+ but WITHOUT ANY WARRANTY; without even the implied warranty of
135+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
136+ GNU General Public License for more details.
137+
138+ You should have received a copy of the GNU General Public License
139+ along with this program. If not, see <http://www.gnu.org/licenses/>.
140+X-Comment: On Debian systems, the complete text of the GNU General
141+ Public License can be found in `/usr/share/common-licenses/GPL-3’.
142+
143+License: LGPL-2.1+
144+ This library is free software; you can redistribute it and/or
145+ modify it under the terms of the GNU Lesser General Public
146+ License as published by the Free Software Foundation; either
147+ version 2.1 of the License, or (at your option) any later version.
148+
149+ This library is distributed in the hope that it will be useful,
150+ but WITHOUT ANY WARRANTY; without even the implied warranty of
151+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
152+ Lesser General Public License for more details.
153+
154+ You should have received a copy of the GNU Lesser General Public License
155+ along with this program. If not, see <http://www.gnu.org/licenses/>.
156+X-Comment: On Debian systems, the complete text of the GNU Lesser General
157+ Public License can be found in `/usr/share/common-licenses/LGPL-2.1’.
158+
159+License: GPL-2+
160+ This program is free software; you can redistribute it and/or modify
161+ it under the terms of the GNU General Public License as published by
162+ the Free Software Foundation; either version 2 of the License, or
163+ (at your option) any later version.
164+
165+ This program is distributed in the hope that it will be useful,
166+ but WITHOUT ANY WARRANTY; without even the implied warranty of
167+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
168+ GNU General Public License for more details.
169+
170+ You should have received a copy of the GNU General Public License
171+ along with this program; if not, write to the Free Software
172+ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
173+X-Comment: On Debian systems, the complete text of the GNU General
174+ Public License can be found in `/usr/share/common-licenses/GPL-2’.
175
176=== added file 'debian/docs'
177--- debian/docs 1970-01-01 00:00:00 +0000
178+++ debian/docs 2010-12-05 14:40:09 +0000
179@@ -0,0 +1,4 @@
180+AUTHORS
181+ChangeLog
182+NEWS
183+README
184
185=== modified file 'debian/rules'
186--- debian/rules 2010-11-07 21:23:15 +0000
187+++ debian/rules 2010-12-05 14:40:09 +0000
188@@ -5,5 +5,5 @@
189
190 override_dh_auto_configure:
191 ./autogen.sh
192- dh_auto_configure
193+ dh_auto_configure -- --enable-indicator=auto
194
195
196=== added file 'debian/watch'
197--- debian/watch 1970-01-01 00:00:00 +0000
198+++ debian/watch 2010-12-05 14:40:09 +0000
199@@ -0,0 +1,2 @@
200+version=3
201+https://launchpad.net/synapse-project/+download http://launchpad.net/synapse-project/.*/synapse-(.+)\.tar.gz