Merge lp:~gilir/file-roller/fix-lp-148084 into lp:~ubuntu-desktop/file-roller/ubuntu

Proposed by Julien Lavergne
Status: Merged
Merged at revision: 41
Proposed branch: lp:~gilir/file-roller/fix-lp-148084
Merge into: lp:~ubuntu-desktop/file-roller/ubuntu
Diff against target: 128 lines (+61/-6)
6 files modified
debian/changelog (+14/-0)
debian/control (+4/-2)
debian/control.in (+4/-2)
debian/patches/90_hyphen_archive_creation.patch (+37/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-2)
To merge this branch: bzr merge lp:~gilir/file-roller/fix-lp-148084
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+46388@code.launchpad.net

Description of the change

This merge request include 3 fixes/changes :
- bug 148084 : Enable pakagekit support, provided by sessioninstaller, to be able to install missing packages.
To test it, you need the version of sessioninstaller on bug 703330 which include fixes for natty.
- bug 689317 : See bug report for detail. This one re-enable ISO support by default. As long as file-roller depends on zip/unzip firstly instead of p7zip, the ISO support is lost.
- bug 671691: Backport a patch from file-roller master, originaly posted on the bug report.

To post a comment you must log in.
lp:~gilir/file-roller/fix-lp-148084 updated
44. By Julien Lavergne

Depends on genisoimage to fix support for iso archive by default
(LP: #689317)

45. By Julien Lavergne

* debian/patches/90_hyphen_archive_creation.patch
 - From upstream, fix archive creation with an hyphen in the name
   (LP: #671691)

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Tested the PackageKit installation with rar and it works. It requires the changes in bug 703330

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-15 21:54:03 +0000
3+++ debian/changelog 2011-01-17 23:30:22 +0000
4@@ -1,3 +1,17 @@
5+file-roller (2.32.1-0ubuntu2) natty; urgency=low
6+
7+ * debian/rules:
8+ - Enable packagekit support (LP: #148084)
9+ * debian/control
10+ - Recommends sessioninstaller | packagekit.
11+ - Depends on genisoimage to fix support for iso archive by default
12+ (LP: #689317)
13+ * debian/patches/90_hyphen_archive_creation.patch
14+ - From upstream, fix archive creation with an hyphen in the name
15+ (LP: #671691)
16+
17+ -- Julien Lavergne <gilir@ubuntu.com> Fri, 14 Jan 2011 22:46:35 +0100
18+
19 file-roller (2.32.1-0ubuntu1) natty; urgency=low
20
21 * New upstream release
22
23=== modified file 'debian/control'
24--- debian/control 2010-08-17 01:43:51 +0000
25+++ debian/control 2011-01-17 23:30:22 +0000
26@@ -36,12 +36,14 @@
27 bzip2 (>= 1.0.1),
28 gzip (>= 1.3.2),
29 unzip | p7zip-full,
30- zip | p7zip-full
31+ zip | p7zip-full,
32+ genisoimage
33 Conflicts: file-roller2
34 Replaces: gnome-icon-theme (<< 2.14)
35 Recommends: gnome-icon-theme (>= 2.18),
36 lzma,
37- gvfs
38+ gvfs,
39+ sessioninstaller | packagekit
40 Suggests: lha,
41 unrar | p7zip-rar,
42 sharutils,
43
44=== modified file 'debian/control.in'
45--- debian/control.in 2010-08-17 01:43:51 +0000
46+++ debian/control.in 2011-01-17 23:30:22 +0000
47@@ -31,12 +31,14 @@
48 bzip2 (>= 1.0.1),
49 gzip (>= 1.3.2),
50 unzip | p7zip-full,
51- zip | p7zip-full
52+ zip | p7zip-full,
53+ genisoimage
54 Conflicts: file-roller2
55 Replaces: gnome-icon-theme (<< 2.14)
56 Recommends: gnome-icon-theme (>= 2.18),
57 lzma,
58- gvfs
59+ gvfs,
60+ sessioninstaller | packagekit
61 Suggests: lha,
62 unrar | p7zip-rar,
63 sharutils,
64
65=== added file 'debian/patches/90_hyphen_archive_creation.patch'
66--- debian/patches/90_hyphen_archive_creation.patch 1970-01-01 00:00:00 +0000
67+++ debian/patches/90_hyphen_archive_creation.patch 2011-01-17 23:30:22 +0000
68@@ -0,0 +1,37 @@
69+From db930e241d450a068e25a9cecb175ea96f787375 Mon Sep 17 00:00:00 2001
70+From: Dmitri Bachtin <d.bachtin@gmail.com>
71+Date: Mon, 17 Jan 2011 09:52:59 +0000
72+Subject: fixed error when creating zip archives with files starting with an hyphen
73+
74+[bug #639664]
75+---
76+diff --git a/src/fr-command-zip.c b/src/fr-command-zip.c
77+index b2157f2..32c4410 100644
78+--- a/src/fr-command-zip.c
79++++ b/src/fr-command-zip.c
80+@@ -252,6 +252,7 @@ fr_command_zip_add (FrCommand *comm,
81+ }
82+
83+ fr_process_add_arg (comm->process, comm->filename);
84++ fr_process_add_arg (comm->process, "--");
85+ for (scan = file_list; scan; scan = scan->next)
86+ fr_process_add_arg (comm->process, scan->data);
87+
88+@@ -274,6 +275,7 @@ fr_command_zip_delete (FrCommand *comm,
89+ fr_process_add_arg (comm->process, "-d");
90+
91+ fr_process_add_arg (comm->process, comm->filename);
92++ fr_process_add_arg (comm->process, "--");
93+ for (scan = file_list; scan; scan = scan->next) {
94+ char *escaped;
95+
96+@@ -318,6 +320,7 @@ fr_command_zip_extract (FrCommand *comm,
97+ add_password_arg (comm, comm->password);
98+
99+ fr_process_add_arg (comm->process, comm->filename);
100++ fr_process_add_arg (comm->process, "--");
101+ for (scan = file_list; scan; scan = scan->next) {
102+ char *escaped;
103+
104+--
105+cgit v0.8.3.1
106
107=== modified file 'debian/patches/series'
108--- debian/patches/series 2010-08-17 01:43:51 +0000
109+++ debian/patches/series 2011-01-17 23:30:22 +0000
110@@ -1,4 +1,5 @@
111 01_menu_change.patch
112 02_lpi.patch
113 20_am-maintainer-mode.patch
114+90_hyphen_archive_creation.patch
115 99_ltmain_as-needed.patch
116
117=== modified file 'debian/rules'
118--- debian/rules 2010-08-09 07:03:10 +0000
119+++ debian/rules 2011-01-17 23:30:22 +0000
120@@ -10,8 +10,7 @@
121
122 LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
123
124-DEB_CONFIGURE_EXTRA_FLAGS += --disable-scrollkeeper \
125- --disable-packagekit
126+DEB_CONFIGURE_EXTRA_FLAGS += --disable-scrollkeeper
127
128 DEB_DH_MAKESHLIBS_ARGS += --no-act
129

Subscribers

People subscribed via source and target branches

to all changes: