Merge lp:~ghugesss/xpad/xpad into lp:xpad
Status: | Merged |
---|---|
Approved by: | Arthur Borsboom on 2014-07-31 |
Approved revision: | no longer in the source branch. |
Merged at revision: | 699 |
Proposed branch: | lp:~ghugesss/xpad/xpad |
Merge into: | lp:xpad |
Diff against target: |
56 lines (+4/-8) 3 files modified
ChangeLog (+1/-0) src/xpad-app.c (+3/-7) src/xpad-pad-group.c (+0/-1) |
To merge this branch: | bzr merge lp:~ghugesss/xpad/xpad |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Arthur Borsboom | quick code test | 2014-07-23 | Approve on 2014-07-31 |
Review via email:
|
Description of the change
Fix seg fault :
We are trying to unref this : gtk_icon_
checked with object ref count every thing looks fine. No other ref remains.
Arthur Borsboom (arthurborsboom) wrote : | # |
Sagar Ghuge (ghugesss) wrote : | # |
Hi,
If I am not wrong then pads are actually our toplevel widgets and we are destroying it. so if we destroy the toplevel widget according to documentation those will gets finalized automatically so I don't think so that we need to set pads to NULL. That's why I removed the code. And if I introduce that line again then it will give me the seg fault. ( as it is already finalized and still we were trying to set it to NULL ) that's why may be.
- 696. By Launchpad Translations on behalf of xpad-team on 2014-07-28
-
Launchpad automatic translations update.
- 697. By Launchpad Translations on behalf of xpad-team on 2014-07-29
-
Launchpad automatic translations update.
- 698. By Launchpad Translations on behalf of xpad-team on 2014-07-30
-
Launchpad automatic translations update.
Arthur Borsboom (arthurborsboom) wrote : | # |
Code looks good.
I did a quick test: run xpad, check preferences, start/stop, etc.
I didn't do a refcount check. We will do this before releasing.
Good job!
- 699. By Arthur Borsboom on 2014-07-31
-
* Fix: Seg Fault - Seg fault on closing the xpad (#1333727)
Hi Sagar,
Most of the offered code looks good and might indeed solve the problem.
What is the reason you take out this piece of code?
group->priv->pads = NULL;