Merge lp:~ghugesss/xpad/xpad into lp:xpad

[Sagar Ghuge]

Fix seg fault :

We are trying to unref this : gtk_icon_theme_get_default (void) but doc says that we should not ref it and unref it.

checked with object ref count every thing looks fine. No other ref remains.

[Arthur Borsboom (arthurborsboom)]

Hi Sagar,

Most of the offered code looks good and might indeed solve the problem.
What is the reason you take out this piece of code?

group->priv->pads = NULL;

[Sagar Ghuge (ghugesss)]

Hi,

If I am not wrong then pads are actually our toplevel widgets and we are destroying it. so if we destroy the toplevel widget according to documentation those will gets finalized automatically so I don't think so that we need to set pads to NULL. That's why I removed the code. And if I introduce that line again then it will give me the seg fault. ( as it is already finalized and still we were trying to set it to NULL ) that's why may be.

[lp:~ghugesss/xpad/xpad]

696. By Launchpad Translations on behalf of xpad-team on 2014-07-28

Launchpad automatic translations update.

697. By Launchpad Translations on behalf of xpad-team on 2014-07-29

Launchpad automatic translations update.

698. By Launchpad Translations on behalf of xpad-team on 2014-07-30

Launchpad automatic translations update.

[Arthur Borsboom (arthurborsboom)]

Code looks good.

I did a quick test: run xpad, check preferences, start/stop, etc.
I didn't do a refcount check. We will do this before releasing.

Good job!

review: Approve (quick code test)

[lp:~ghugesss/xpad/xpad]

699. By Arthur Borsboom on 2014-07-31

* Fix: Seg Fault - Seg fault on closing the xpad (#1333727)

=== modified file 'ChangeLog'
--- ChangeLog	2014-07-20 16:36:07 +0000
+++ ChangeLog	2014-07-23 11:11:38 +0000
@@ -1,5 +1,6 @@
 Version 4.4
 * Fix: Preferences - redesign of preferences box to make sure it fits on small screens (#1333636)
+* Fix: Seg Fault - Seg fault on closing the xpad (#1333727)
 
 Version 4.3
 * New: Systray - ability to hide the tray icon (#890334) 

=== modified file 'src/xpad-app.c'
--- src/xpad-app.c	2014-06-19 19:33:52 +0000
+++ src/xpad-app.c	2014-07-23 11:11:38 +0000
@@ -245,15 +245,13 @@
 void
 xpad_app_quit (void)
 {
-	/* Give GTK the signal to clean the rest and quit the application. */
-	gtk_main_quit ();
-
 	/* Free the memory used by the pads belonging to this group */
 	xpad_pad_group_destroy_pads (pad_group);
 
 	/* Free the memory used by group. */
 	if (G_IS_OBJECT (pad_group))
 		g_object_unref (pad_group);
+	pad_group = NULL;
 
 	/* Free the memory used by the tray icon and its menu. */
 	xpad_tray_dispose (settings);
@@ -263,10 +261,8 @@
 		g_object_unref (settings);
 	settings = NULL; /* This is needed due to the asynchronous finalizing process. */
 
-	/* Free the theme reference. Unfortunately GTK3 leaves about 600 objects behind. */
-	if (G_IS_OBJECT (gtk_icon_theme_get_default ()))
-		g_object_unref (gtk_icon_theme_get_default ());
-
+	/* Give GTK the signal to clean the rest and quit the application. */
+	gtk_main_quit ();
 }
 
 static gboolean

=== modified file 'src/xpad-pad-group.c'
--- src/xpad-pad-group.c	2014-06-20 10:23:13 +0000
+++ src/xpad-pad-group.c	2014-07-23 11:11:38 +0000
@@ -124,7 +124,6 @@
 	xpad_pad_group_save_unsaved_all(group);
 
 	g_slist_foreach (group->priv->pads, (GFunc) gtk_widget_destroy, NULL);
-	group->priv->pads = NULL;
 }
 
 guint