Merge lp:~ghugesss/gtg/patches into lp:~gtg/gtg/old-trunk

Proposed by Sagar Ghuge on 2014-03-11
Status: Merged
Merged at revision: 1368
Proposed branch: lp:~ghugesss/gtg/patches
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 38 lines (+3/-4)
1 file modified
GTG/gtk/editor/taskview.py (+3/-4)
To merge this branch: bzr merge lp:~ghugesss/gtg/patches
Reviewer Review Type Date Requested Status
Nimit Shah 2014-03-13 Needs Fixing on 2014-03-14
Parin Porecha 2014-03-11 Needs Fixing on 2014-03-11
Review via email: mp+210341@code.launchpad.net

Commit message

 '.data' access removed, and replaced with the right method call

Description of the change

SelectionData patched

To post a comment you must log in.
Parin Porecha (parinporecha) wrote :

Hi,

I receive this error traceback by doing a drag-n-drop in the task editor -

Traceback (most recent call last):
  File "/home/manhattan/GTG_POST_MERGE/trunk2/GTG/gtk/editor/taskview.py", line 185, in drag_receive
    self.buff.insert_at_cursor(selection.get_text())
  File "/usr/lib/python3.3/site-packages/gi/overrides/Gtk.py", line 703, in insert_at_cursor
    raise TypeError('text must be a string, not %s' % type(text))
TypeError: text must be a string, not <class 'NoneType'>

review: Needs Fixing
lp:~ghugesss/gtg/patches updated on 2014-03-12
1365. By Sagar Ghuge on 2014-03-12

.data removed and right method called

1366. By Sagar Ghuge on 2014-03-12

unnecessary import removed

Nimit Shah (nimit-svnit) wrote :

What is the purpose of this merge? What issue does this wish to solve?
If it is preventing drag n drop of tasks in Workview then it is not working.

review: Needs Information
Sagar Ghuge (ghugesss) wrote :

Hi,

Issue which is noticed :-

http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/gtk/editor/taskview.py#L185

.data is not a attribute of GtkSelectionData. so while draging any content
from any source to task editor it throws an error.

Considering this submitted patch.

I hope this much information is sufficient if not let me know.

On Fri, Mar 14, 2014 at 12:47 AM, Nimit Shah <email address hidden> wrote:

> Review: Needs Information
>
> What is the purpose of this merge? What issue does this wish to solve?
> If it is preventing drag n drop of tasks in Workview then it is not
> working.
> --
> https://code.launchpad.net/~ghugesss/gtg/patches/+merge/210341
> You are the owner of lp:~ghugesss/gtg/patches.
>

--

*Regards,Sagar*

Nimit Shah (nimit-svnit) wrote :

Hi Sagar,
Your fix seems to be duplicating the data of the task editor. I'll attach screenshots with the next mail.

review: Needs Fixing
lp:~ghugesss/gtg/patches updated on 2014-03-16
1367. By Sagar Ghuge <email address hidden> on 2014-03-16

drag_receive changed.

Sagar Ghuge (ghugesss) wrote :

Hi Nimit,

I have updated branch. Can you review it now.

> Hi Sagar,
> Your fix seems to be duplicating the data of the task editor. I'll attach
> screenshots with the next mail.

Nimit Shah (nimit-svnit) wrote :

Hi Sagar,
You seem to have a pep8 error in your code. Please correct it and also,
update the copyright year of taskedview.py to 2008 - 2014.

Nimit Shah

On Sun, Mar 16, 2014 at 3:29 PM, Sagar Ghuge <email address hidden> wrote:

> Hi Nimit,
>
> I have updated branch. Can you review it now.
>
> > Hi Sagar,
> > Your fix seems to be duplicating the data of the task editor. I'll attach
> > screenshots with the next mail.
> --
> https://code.launchpad.net/~ghugesss/gtg/patches/+merge/210341
> You are reviewing the proposed merge of lp:~ghugesss/gtg/patches into
> lp:gtg.
>

lp:~ghugesss/gtg/patches updated on 2014-03-16
1368. By Sagar Ghuge on 2014-03-16

pep8 error corrected and copyright updated

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GTG/gtk/editor/taskview.py'
2--- GTG/gtk/editor/taskview.py 2013-11-25 02:37:46 +0000
3+++ GTG/gtk/editor/taskview.py 2014-03-16 18:06:58 +0000
4@@ -1,7 +1,7 @@
5 # -*- coding: utf-8 -*-
6 # -----------------------------------------------------------------------------
7 # Getting Things GNOME! - a personal organizer for the GNOME desktop
8-# Copyright (c) 2008-2013 - Lionel Dricot & Bertrand Rousseau
9+# Copyright (c) 2008-2014 - Lionel Dricot & Bertrand Rousseau
10 #
11 # This program is free software: you can redistribute it and/or modify it under
12 # the terms of the GNU General Public License as published by the Free Software
13@@ -134,7 +134,7 @@
14 self.connect('cut-clipboard', self.copy_clipboard, "cut")
15 self.connect('paste-clipboard', self.paste_clipboard)
16
17- self.connect('drag-data-received', self.drag_receive)
18+ self.connect_after('drag-data-received', self.drag_receive)
19
20 # All the typical properties of our textview
21 self.set_wrap_mode(Gtk.WrapMode.WORD)
22@@ -182,7 +182,6 @@
23 """ After drag and drop just insert it and refresh the editor
24
25 Example usage: drag and drop of file links """
26- self.buff.insert_at_cursor(selection.data)
27 self.modified(full=True)
28 self.stop_emission('drag-data-received')
29
30@@ -248,7 +247,7 @@
31 # Buffer related functions
32 # Those functions are higly related and should always be symetrical
33 # See also the serializing functions
34- #### The "Set text" group ########
35+ #### The "Set text" group ########
36 # This set the text of the buffer (and replace any existing one)
37 # without deserializing (used for the title)
38 def set_text(self, stri):

Subscribers

People subscribed via source and target branches

to status/vote changes: