Code review comment for lp:~gholt/swift/logroutes

Revision history for this message
clayg (clay-gerrard) wrote :

Calling get_logger with a log_route kwarg instead of name as a positional argument isn't really the same thing. It may even have some side-effects that weren't intended?

e.g.
the drive-audit script logs as "swift" instead of "drive-audit"
swift-account-stats-logger logs as "log-processor-stats" instead of "swift-account-stats-logger" or just "account-stats"

I think things mostly sorta "work" because these conf dicts are coming out of readconf and run_wsgi which will both throw in a log_name key set to the section_name if there isn't something there already.

On the other hand... with this branch I can finally set a log_name for the auditors, updaters and replicators... so maybe it's a net gain?

« Back to merge proposal