Merge lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading into lp:ubuntu/lucid/unetbootin

Proposed by Geza Kovacs
Status: Rejected
Rejected by: Luke Faraone
Proposed branch: lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading
Merge into: lp:ubuntu/lucid/unetbootin
Diff against target: 155 lines (+69/-7)
5 files modified
debian/changelog (+12/-0)
debian/control (+2/-1)
distrolst.cpp (+1/-1)
distrover.cpp (+4/-3)
unetbootin.cpp (+50/-2)
To merge this branch: bzr merge lp:~gezakovacs/ubuntu/lucid/unetbootin/fix-10.10-desktop-iso-loading
Reviewer Review Type Date Requested Status
Luke Faraone procedural Disapprove
Review via email: mp+37782@code.launchpad.net

Description of the change

Fixes generated menu entries when loading Ubuntu 10.10 desktop iso. Has been tested against ubuntu-10.10-rc-desktop-amd64.iso and ubuntu-10.04-desktop-i386.iso

To post a comment you must log in.
Revision history for this message
Luke Faraone (lfaraone) wrote :

FYI, I think you meant to merge this into lucid-updates. I've proposed a merge into -updates for you and will review shortly.

review: Disapprove (procedural)

Unmerged revisions

17. By Geza Kovacs

Fixes issues when loading Ubuntu 10.10 desktop iso. (LP: #615285)

16. By Luke Faraone

Include Ubuntu 10.04 LTS in the dropdown list for Ubuntu. (LP: #578841)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-02-14 09:16:41 +0000
3+++ debian/changelog 2010-10-06 20:05:57 +0000
4@@ -1,3 +1,15 @@
5+unetbootin (408-1ubuntu1.10.04.1) lucid-proposed; urgency=low
6+
7+ * Fixes issues when loading Ubuntu 10.10 desktop iso. (LP: #615285)
8+
9+ -- Geza Kovacs <gkovacs@mit.edu> Wed, 06 Oct 2010 15:33:58 -0400
10+
11+unetbootin (408-1ubuntu0.10.04.1) lucid-proposed; urgency=low
12+
13+ * Include Ubuntu 10.04 LTS in the dropdown list for Ubuntu. (LP: #578841)
14+
15+ -- Luke Faraone <luke@faraone.cc> Tue, 11 May 2010 11:11:22 -0400
16+
17 unetbootin (408-1) unstable; urgency=low
18
19 * New upstream release.
20
21=== modified file 'debian/control'
22--- debian/control 2009-09-27 14:48:46 +0000
23+++ debian/control 2010-10-06 20:05:57 +0000
24@@ -1,7 +1,8 @@
25 Source: unetbootin
26 Section: utils
27 Priority: optional
28-Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>
29+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
30+XSBC-Original-Maintainer: Eugene V. Lyubimkin <jackyf@debian.org>
31 Build-Depends: syslinux, debhelper (>= 7), libqt4-dev (>= 4.2)
32 Standards-Version: 3.8.3
33 Vcs-Git: git://git.debian.org/git/collab-maint/unetbootin.git
34
35=== modified file 'distrolst.cpp'
36--- distrolst.cpp 2010-02-14 09:16:41 +0000
37+++ distrolst.cpp 2010-10-06 20:05:57 +0000
38@@ -14,7 +14,7 @@
39
40 #ifndef ubunturelnamereplace
41 #define ubunturelnamereplace \
42- relname.replace("9.10", "karmic").replace("9.04", "jaunty").replace("8.10", "intrepid").replace("8.04", "hardy").replace("7.10", "gutsy").replace("7.04", "feisty").replace("6.10", "edgy").replace("6.06", "dapper");
43+ relname.replace("10.04", "lucid").replace("9.10", "karmic").replace("9.04", "jaunty").replace("8.10", "intrepid").replace("8.04", "hardy").replace("7.10", "gutsy").replace("7.04", "feisty").replace("6.10", "edgy").replace("6.06", "dapper");
44 #endif
45
46 #ifndef ubuntunetinst
47
48=== modified file 'distrover.cpp'
49--- distrover.cpp 2010-02-14 09:16:41 +0000
50+++ distrover.cpp 2010-10-06 20:05:57 +0000
51@@ -14,6 +14,7 @@
52 "8.10_NetInstall" << "8.10_NetInstall_x64" << "8.10_HdMedia" << "8.10_HdMedia_x64" << "8.10_Live" << "8.10_Live_x64" << \
53 "9.04_NetInstall" << "9.04_NetInstall_x64" << "9.04_HdMedia" << "9.04_HdMedia_x64" << "9.04_Live" << "9.04_Live_x64" << \
54 "9.10_NetInstall" << "9.10_NetInstall_x64" << "9.10_HdMedia" << "9.10_HdMedia_x64" << "9.10_Live" << "9.10_Live_x64" << \
55+"10.04_NetInstall" << "10.04_NetInstall_x64" << "10.04_HdMedia" << "10.04_HdMedia_x64" << "10.04_Live" << "10.04_Live_x64" << \
56 "Daily_Live" << "Daily_Live_x64"
57 #endif
58
59@@ -129,7 +130,7 @@
60 "<b>Description:</b> Kaspersky Rescue Disk detects and removes malware from your Windows installation.<br/>"
61 "<b>Install Notes:</b> The Live version allows for booting in Live mode, from which malware scans can be launched.") <<
62 "Latest_Live"));
63- distroselect->addItem("Kubuntu", (QStringList() << "9.10_Live" <<
64+ distroselect->addItem("Kubuntu", (QStringList() << "10.04_Live" <<
65 unetbootin::tr("<b>Homepage:</b> <a href=\"http://www.kubuntu.org/\">http://www.kubuntu.org</a><br/>"
66 "<b>Description:</b> Kubuntu is an official Ubuntu derivative featuring the KDE desktop.<br/>"
67 "<b>Install Notes:</b> The Live version allows for booting in Live mode, from which the installer can optionally be launched. The NetInstall version allows for installation over FTP, and can install Kubuntu and other official Ubuntu derivatives. If you would like to use a pre-downloaded alternate (not desktop) install iso, use the HdMedia option, and then place the alternate install iso file on the root directory of your hard drive or USB drive") <<
68@@ -220,7 +221,7 @@
69 "<b>Description:</b> SystemRescueCD includes various partition management and data recovery and backup tools.<br/>"
70 "<b>Install Notes:</b> SystemRescueCD is booted and run in live mode; no installation is required to use it.") <<
71 "Latest_Live"));
72-distroselect->addItem("Ubuntu", (QStringList() << "9.10_Live" <<
73+distroselect->addItem("Ubuntu", (QStringList() << "10.04_Live" <<
74 unetbootin::tr("<b>Homepage:</b> <a href=\"http://www.ubuntu.com/\">http://www.ubuntu.com</a><br/>"
75 "<b>Description:</b> Ubuntu is a user-friendly Debian-based distribution. It is currently the most popular Linux desktop distribution.<br/>"
76 "<b>Install Notes:</b> The Live version allows for booting in Live mode, from which the installer can optionally be launched. The NetInstall version allows for installation over FTP, and can install Kubuntu and other official Ubuntu derivatives. If you would like to use a pre-downloaded alternate (not desktop) install iso, use the HdMedia option, and then place the alternate install iso file on the root directory of your hard drive or USB drive") <<
77@@ -230,7 +231,7 @@
78 "<b>Description:</b> xPUD is a lightweight distribution featuring a simple kiosk-like interface with a web browser and media player.<br/>"
79 "<b>Install Notes:</b> The Live version loads the entire system into RAM and boots from memory.") <<
80 "Stable_Live" << "Unstable_Live"));
81-distroselect->addItem("Xubuntu", (QStringList() << "9.10_Live" <<
82+distroselect->addItem("Xubuntu", (QStringList() << "10.04_Live" <<
83 unetbootin::tr("<b>Homepage:</b> <a href=\"http://www.xubuntu.org/\">http://www.xubuntu.org</a><br/>"
84 "<b>Description:</b> Xubuntu is an official Ubuntu derivative featuring the XFCE desktop.<br/>"
85 "<b>Install Notes:</b> The Live version allows for booting in Live mode, from which the installer can optionally be launched. The NetInstall version allows for installation over FTP, and can install Kubuntu and other official Ubuntu derivatives. If you would like to use a pre-downloaded alternate (not desktop) install iso, use the HdMedia option, and then place the alternate install iso file on the root directory of your hard drive or USB drive") <<
86
87=== modified file 'unetbootin.cpp'
88--- unetbootin.cpp 2010-02-14 09:16:41 +0000
89+++ unetbootin.cpp 2010-10-06 20:05:57 +0000
90@@ -1636,7 +1636,31 @@
91 {
92 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
93 }
94- QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
95+ QStringList includesfileL;
96+ for (int i = 0; i < archivefileconts.size(); ++i)
97+ {
98+ QString curentry = archivefileconts.at(i);
99+ if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
100+ {
101+ curentry = curentry.left(curentry.size() - 1).trimmed();
102+ }
103+ if (curentry.contains("/"))
104+ {
105+ curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
106+ }
107+ else if (curentry.contains(QDir::toNativeSeparators("/")))
108+ {
109+ curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
110+ }
111+ if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
112+ {
113+ includesfileL.append(archivefileconts.at(i));
114+ }
115+ }
116+ if (includesfileL.isEmpty())
117+ {
118+ includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
119+ }
120 if (!includesfileL.isEmpty())
121 {
122 for (int i = 0; i < includesfileL.size(); ++i)
123@@ -1660,7 +1684,31 @@
124 {
125 includesfile = includesfile.right(includesfile.size() - 1).trimmed();
126 }
127- QStringList includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
128+ QStringList includesfileL;
129+ for (int i = 0; i < archivefileconts.size(); ++i)
130+ {
131+ QString curentry = archivefileconts.at(i);
132+ if (curentry.endsWith("/") || curentry.endsWith(QDir::toNativeSeparators("/")))
133+ {
134+ curentry = curentry.left(curentry.size() - 1).trimmed();
135+ }
136+ if (curentry.contains("/"))
137+ {
138+ curentry = curentry.right(curentry.size() - 1 - curentry.indexOf("/"));
139+ }
140+ else if (curentry.contains(QDir::toNativeSeparators("/")))
141+ {
142+ curentry = curentry.right(curentry.size() - 1 - curentry.indexOf(QDir::toNativeSeparators("/")));
143+ }
144+ if (includesfile.compare(curentry, Qt::CaseInsensitive) == 0)
145+ {
146+ includesfileL.append(archivefileconts.at(i));
147+ }
148+ }
149+ if (includesfileL.isEmpty())
150+ {
151+ includesfileL = archivefileconts.filter(includesfile, Qt::CaseInsensitive);
152+ }
153 if (!includesfileL.isEmpty())
154 {
155 for (int i = 0; i < includesfileL.size(); ++i)

Subscribers

People subscribed via source and target branches

to all changes: