Merge lp:~gesha/linaro-license-protection/add-ordereddict-class into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by Georgy Redkozubov
Status: Merged
Approved by: Данило Шеган
Approved revision: 143
Merged at revision: 143
Proposed branch: lp:~gesha/linaro-license-protection/add-ordereddict-class
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 296 lines (+272/-2)
2 files modified
license_protected_downloads/OrderedDict.py (+270/-0)
license_protected_downloads/render_text_files.py (+2/-2)
To merge this branch: bzr merge lp:~gesha/linaro-license-protection/add-ordereddict-class
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+131071@code.launchpad.net

Description of the change

This branch adds backported from python 2.7 OrderedDict class since it's not available in 2.6 which is on mombin.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Please add a reference to where the code was taken from (i.e. http://code.activestate.com/recipes/576693/)

We should definitely upgrade mombin to 12.04 asap.

Revision history for this message
Данило Шеган (danilo) :
review: Approve
144. By Georgy Redkozubov

Added reference to the original site

145. By Georgy Redkozubov

Fixed pep8 errors in OrderedDict class

146. By Georgy Redkozubov

Fixed pyflakes 'redefenition of unused import' error in OrderedDict class

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'license_protected_downloads/OrderedDict.py'
2--- license_protected_downloads/OrderedDict.py 1970-01-01 00:00:00 +0000
3+++ license_protected_downloads/OrderedDict.py 2012-10-23 19:38:23 +0000
4@@ -0,0 +1,270 @@
5+# Backport of OrderedDict() class that runs on Python 2.4, 2.5, 2.6, 2.7
6+# and pypy.
7+# Passes Python2.7's test suite and incorporates all the latest updates.
8+#
9+# This code was taken from http://code.activestate.com/recipes/576693/
10+
11+try:
12+ import thread
13+ _get_ident = thread.get_ident
14+except ImportError:
15+ from dummy_thread import get_ident as _get_ident
16+
17+try:
18+ from _abcoll import KeysView, ValuesView, ItemsView
19+except ImportError:
20+ pass
21+
22+
23+class OrderedDict(dict):
24+ 'Dictionary that remembers insertion order'
25+ # An inherited dict maps keys to values.
26+ # The inherited dict provides __getitem__, __len__, __contains__, and get.
27+ # The remaining methods are order-aware.
28+ # Big-O running times for all methods are the same as for regular
29+ # dictionaries.
30+
31+ # The internal self.__map dictionary maps keys to links in a doubly linked
32+ # list.
33+ # The circular doubly linked list starts and ends with a sentinel element.
34+ # The sentinel element never gets deleted (this simplifies the algorithm).
35+ # Each link is stored as a list of length three: [PREV, NEXT, KEY].
36+
37+ def __init__(self, *args, **kwds):
38+ '''Initialize an ordered dictionary. Signature is the same as for
39+ regular dictionaries, but keyword arguments are not recommended
40+ because their insertion order is arbitrary.
41+
42+ '''
43+ if len(args) > 1:
44+ raise TypeError('expected at most 1 arguments, got %d' % len(args))
45+ try:
46+ self.__root
47+ except AttributeError:
48+ self.__root = root = [] # sentinel node
49+ root[:] = [root, root, None]
50+ self.__map = {}
51+ self.__update(*args, **kwds)
52+
53+ def __setitem__(self, key, value, dict_setitem=dict.__setitem__):
54+ 'od.__setitem__(i, y) <==> od[i]=y'
55+ # Setting a new item creates a new link which goes at the end of the
56+ # linked list, and the inherited dictionary is updated with the new
57+ # key/value pair.
58+ if key not in self:
59+ root = self.__root
60+ last = root[0]
61+ last[1] = root[0] = self.__map[key] = [last, root, key]
62+ dict_setitem(self, key, value)
63+
64+ def __delitem__(self, key, dict_delitem=dict.__delitem__):
65+ 'od.__delitem__(y) <==> del od[y]'
66+ # Deleting an existing item uses self.__map to find the link which is
67+ # then removed by updating the links in the predecessor and successor
68+ # nodes.
69+ dict_delitem(self, key)
70+ link_prev, link_next, key = self.__map.pop(key)
71+ link_prev[1] = link_next
72+ link_next[0] = link_prev
73+
74+ def __iter__(self):
75+ 'od.__iter__() <==> iter(od)'
76+ root = self.__root
77+ curr = root[1]
78+ while curr is not root:
79+ yield curr[2]
80+ curr = curr[1]
81+
82+ def __reversed__(self):
83+ 'od.__reversed__() <==> reversed(od)'
84+ root = self.__root
85+ curr = root[0]
86+ while curr is not root:
87+ yield curr[2]
88+ curr = curr[0]
89+
90+ def clear(self):
91+ 'od.clear() -> None. Remove all items from od.'
92+ try:
93+ for node in self.__map.itervalues():
94+ del node[:]
95+ root = self.__root
96+ root[:] = [root, root, None]
97+ self.__map.clear()
98+ except AttributeError:
99+ pass
100+ dict.clear(self)
101+
102+ def popitem(self, last=True):
103+ '''od.popitem() -> (k, v), return and remove a (key, value) pair.
104+ Pairs are returned in LIFO order if last is true or FIFO order if
105+ false.
106+
107+ '''
108+ if not self:
109+ raise KeyError('dictionary is empty')
110+ root = self.__root
111+ if last:
112+ link = root[0]
113+ link_prev = link[0]
114+ link_prev[1] = root
115+ root[0] = link_prev
116+ else:
117+ link = root[1]
118+ link_next = link[1]
119+ root[1] = link_next
120+ link_next[0] = root
121+ key = link[2]
122+ del self.__map[key]
123+ value = dict.pop(self, key)
124+ return key, value
125+
126+ # -- the following methods do not depend on the internal structure --
127+
128+ def keys(self):
129+ 'od.keys() -> list of keys in od'
130+ return list(self)
131+
132+ def values(self):
133+ 'od.values() -> list of values in od'
134+ return [self[key] for key in self]
135+
136+ def items(self):
137+ 'od.items() -> list of (key, value) pairs in od'
138+ return [(key, self[key]) for key in self]
139+
140+ def iterkeys(self):
141+ 'od.iterkeys() -> an iterator over the keys in od'
142+ return iter(self)
143+
144+ def itervalues(self):
145+ 'od.itervalues -> an iterator over the values in od'
146+ for k in self:
147+ yield self[k]
148+
149+ def iteritems(self):
150+ 'od.iteritems -> an iterator over the (key, value) items in od'
151+ for k in self:
152+ yield (k, self[k])
153+
154+ def update(*args, **kwds):
155+ '''od.update(E, **F) -> None. Update od from dict/iterable E and F.
156+
157+ If E is a dict instance, does: for k in E: od[k] = E[k]
158+ If E has a .keys() method, does: for k in E.keys(): od[k] = E[k]
159+ Or if E is an iterable of items, does: for k, v in E: od[k] = v
160+ In either case, this is followed by: for k, v in F.items(): od[k] = v
161+ '''
162+ if len(args) > 2:
163+ raise TypeError('update() takes at most 2 positional '
164+ 'arguments (%d given)' % (len(args),))
165+ elif not args:
166+ raise TypeError('update() takes at least 1 argument (0 given)')
167+ self = args[0]
168+ # Make progressively weaker assumptions about "other"
169+ other = ()
170+ if len(args) == 2:
171+ other = args[1]
172+ if isinstance(other, dict):
173+ for key in other:
174+ self[key] = other[key]
175+ elif hasattr(other, 'keys'):
176+ for key in other.keys():
177+ self[key] = other[key]
178+ else:
179+ for key, value in other:
180+ self[key] = value
181+ for key, value in kwds.items():
182+ self[key] = value
183+
184+ # let subclasses override update without breaking __init__
185+ __update = update
186+
187+ __marker = object()
188+
189+ def pop(self, key, default=__marker):
190+ '''od.pop(k[,d]) -> v, remove specified key and return the
191+ corresponding value.
192+ If key is not found, d is returned if given, otherwise KeyError is
193+ raised.
194+
195+ '''
196+ if key in self:
197+ result = self[key]
198+ del self[key]
199+ return result
200+ if default is self.__marker:
201+ raise KeyError(key)
202+ return default
203+
204+ def setdefault(self, key, default=None):
205+ 'od.setdefault(k[,d]) -> od.get(k,d), also set od[k]=d if k not in od'
206+ if key in self:
207+ return self[key]
208+ self[key] = default
209+ return default
210+
211+ def __repr__(self, _repr_running={}):
212+ 'od.__repr__() <==> repr(od)'
213+ call_key = id(self), _get_ident()
214+ if call_key in _repr_running:
215+ return '...'
216+ _repr_running[call_key] = 1
217+ try:
218+ if not self:
219+ return '%s()' % (self.__class__.__name__,)
220+ return '%s(%r)' % (self.__class__.__name__, self.items())
221+ finally:
222+ del _repr_running[call_key]
223+
224+ def __reduce__(self):
225+ 'Return state information for pickling'
226+ items = [[k, self[k]] for k in self]
227+ inst_dict = vars(self).copy()
228+ for k in vars(OrderedDict()):
229+ inst_dict.pop(k, None)
230+ if inst_dict:
231+ return (self.__class__, (items,), inst_dict)
232+ return self.__class__, (items,)
233+
234+ def copy(self):
235+ 'od.copy() -> a shallow copy of od'
236+ return self.__class__(self)
237+
238+ @classmethod
239+ def fromkeys(cls, iterable, value=None):
240+ '''OD.fromkeys(S[, v]) -> New ordered dictionary with keys from S
241+ and values equal to v (which defaults to None).
242+
243+ '''
244+ d = cls()
245+ for key in iterable:
246+ d[key] = value
247+ return d
248+
249+ def __eq__(self, other):
250+ '''od.__eq__(y) <==> od==y. Comparison to another OD is
251+ order-sensitive while comparison to a regular mapping is
252+ order-insensitive.
253+
254+ '''
255+ if isinstance(other, OrderedDict):
256+ return len(self) == len(other) and self.items() == other.items()
257+ return dict.__eq__(self, other)
258+
259+ def __ne__(self, other):
260+ return not self == other
261+
262+ # -- the following methods are only used in Python 2.7 --
263+
264+ def viewkeys(self):
265+ "od.viewkeys() -> a set-like object providing a view on od's keys"
266+ return KeysView(self)
267+
268+ def viewvalues(self):
269+ "od.viewvalues() -> an object providing a view on od's values"
270+ return ValuesView(self)
271+
272+ def viewitems(self):
273+ "od.viewitems() -> a set-like object providing a view on od's items"
274+ return ItemsView(self)
275
276=== modified file 'license_protected_downloads/render_text_files.py'
277--- license_protected_downloads/render_text_files.py 2012-10-23 12:37:11 +0000
278+++ license_protected_downloads/render_text_files.py 2012-10-23 19:38:23 +0000
279@@ -1,7 +1,7 @@
280 import os
281 import re
282 import textile
283-from collections import OrderedDict
284+import OrderedDict
285 from django.conf import settings
286
287
288@@ -48,7 +48,7 @@
289 return None
290
291 result_items = sorted(result.items(), cmp=cls.sort_tabs_by_priority)
292- result = OrderedDict()
293+ result = OrderedDict.OrderedDict()
294 for v, k in result_items:
295 result[v] = k
296 return result

Subscribers

People subscribed via source and target branches