Merge lp:~gesha/linaro-image-tools/README into lp:linaro-image-tools/11.11

Proposed by Georgy Redkozubov
Status: Merged
Approved by: Данило Шеган
Approved revision: 470
Merged at revision: 470
Proposed branch: lp:~gesha/linaro-image-tools/README
Merge into: lp:linaro-image-tools/11.11
Diff against target: 10 lines (+1/-0)
1 file modified
README (+1/-0)
To merge this branch: bzr merge lp:~gesha/linaro-image-tools/README
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+83787@code.launchpad.net

Description of the change

This branch adds python-yaml package to the dependency list

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Georgy, thanks for working on this. I will use this as an opportunity to raise a few things: your fix is naturally just fine :)

First of, it would be nice to confirm that you have run the full test suite, as described in the README itself, so I can be certain that these dependencies have really made it work for you. And especially, in the true test-driven development spirit, it would have been nice if you confirmed that the test suite fails without python-yaml, and that it passes with it: this ensures that the problem is indeed solved by installing python-yaml.

Next, if you don't set the reviewer explicitely, anyone in the linaro-image-tools reviewers team can take a look, and that's generally a better approach: you ask for an explicit reviewer only when that person is really the best person to review the change. In this particular case, choosing me is good, but don't feel bad about getting a review from anyone else.

Also, there is no need to attach a patch to the bug report manually: if you go to the bug 897577 page now, you can see that Launchpad adds the information about this merge proposal, including an easy to see diff, so all you need to do is to add a merge proposal, and a diff will automatically be available.

After this review is approved, you should be able to merge this change into the trunk branch as well yourself using the following procedure:

  bzr branch lp:linaro-image-tools lit-trunk
  cd lit-trunk
  bzr merge lp:~georgy-redkozubov/linaro-image-tools/README
  bzr diff # To review changes and ensure nothing else is changed.
  bzr ci -m '[r=danilo] Add python-yaml to the list of dependencies in the README file. Fixes bug 897577.'
  bzr push lp:linaro-image-tools

(this approach ensures we have a nice history and reduce the chances of overlapping histories - i.e. we only add to trunk, do not rebase it - since that's a natural approach to working with branches and bazaar)

If you need help in any of these steps, feel free to ask about it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2011-11-21 19:44:39 +0000
3+++ README 2011-11-29 14:06:59 +0000
4@@ -18,6 +18,7 @@
5 - command-not-found
6 - python-testtools >= 0.9.8
7 (available at https://launchpad.net/~linaro-maintainers/+archive/tools)
8+ - python-yaml
9
10 = Running tests =
11

Subscribers

People subscribed via source and target branches