Merge lp:~gesha/linaro-ci-dashboard/detail-view-tests-update into lp:linaro-ci-dashboard

[Georgy Redkozubov]

Added client response test for detail view page.
Fixed Milo's test that passed in "false-positive" way.

[Milo Casagrande (milo)]

Hey gesha! Thanks for fixing this and for the new test.
Looks good to me.

review: Approve

=== modified file 'dashboard/frontend/android_build/tests/test_android_build_clientresponse.py'
--- dashboard/frontend/android_build/tests/test_android_build_clientresponse.py	2012-08-17 14:20:47 +0000
+++ dashboard/frontend/android_build/tests/test_android_build_clientresponse.py	2012-08-21 06:59:19 +0000
@@ -14,6 +14,7 @@
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with linaro-ci-dashboard.  If not, see <http://www.gnu.org/licenses/>.
+import urlparse
 
 from frontend.tests.test_clientresponse import ClientResponseTestsGeneral
 
@@ -24,6 +25,13 @@
         super(AndroidBuildClientResponseTests, self).setUp()
         self.android_build_data = {"name" : "a-build",
                                    "build_type" : "build-android",
+                                   "manifest_repo" : "repo",
+                                   "manifest_branch" : "branch",
+                                   "manifest_filename" : "filename",
+                                   "make_jobs" : "2",
+                                   "ramdisk_size" : "2",
+                                   "binutils_version" : "1",
+                                   "gcc_version" : "1"
                                     }
 
     def test_android_build_create_get(self):
@@ -51,13 +59,36 @@
                                     self.android_build_data, follow=True)
         # Assert response code.
         self.assertEquals(response.status_code, 200)
+        # Assert content for required fields filled
+        self.assertNotIn("This field is required", response.content)
         # Assert template names for detail page.
         template_names = [template.name for template in
                           response.templates]
-        self.assertEquals(template_names, ["android_loop_create.html",
+        self.assertEquals(template_names, ["android_loop_detail.html",
                                            "base.html",
                                            "login.html",
                                            ])
         # Assert if everything is present on detail page.
         self.assertIn(self.android_build_data["name"], response.content)
-        self.assertIn(self.android_build_data["build_type"], response.content)
\ No newline at end of file
+        self.assertIn(self.android_build_data["build_type"], response.content)
+
+    def test_android_build_detail_get(self):
+        self.client.login(username=self.user, password=self.passwd)
+
+        # Follow redirect after save.
+        target_file = "/android/create/"
+        url = urlparse.urljoin("http://testserver/", target_file)
+        response = self.client.post(url, self.android_build_data, follow=True)
+        # Assert response code.
+        self.assertEquals(response.status_code, 200)
+        # Assert content for required fields filled
+        self.assertNotIn("This field is required", response.content)
+
+        target_file = "/android/detail/%s/" % self.android_build_data["name"]
+        url = urlparse.urljoin("http://testserver/", target_file)
+        response = self.client.get(url, follow=True)
+        # Assert response code.
+        self.assertEquals(response.status_code, 200)
+        self.assertIn("Details", response.content)
+        self.assertIn("Build type", response.content)
+