Merge lp:~gesha/linaro-android-frontend/show-member-daily-builds into lp:linaro-android-frontend

Proposed by Georgy Redkozubov
Status: Merged
Merged at revision: 301
Proposed branch: lp:~gesha/linaro-android-frontend/show-member-daily-builds
Merge into: lp:linaro-android-frontend
Diff against target: 130 lines (+4/-60)
1 file modified
static/index.js (+4/-60)
To merge this branch: bzr merge lp:~gesha/linaro-android-frontend/show-member-daily-builds
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+144441@code.launchpad.net

Description of the change

Member daily and release builds should be visible to anybody.

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

It looks to go for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/index.js'
2--- static/index.js 2013-01-22 07:27:00 +0000
3+++ static/index.js 2013-01-23 07:15:24 +0000
4@@ -108,19 +108,6 @@
5 mti_tabview.on(
6 'render',
7 function (e) {
8- if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-ti')) {
9- var dailyBuildsTab = mti_tabview.item(0);
10- mti_tabview.item(0).hide();
11- var releaseBuildsTab = mti_tabview.item(1);
12- dailyBuildsTab.on('click', function (e) { e.preventDefault(); });
13- releaseBuildsTab.on('click', function (e) { e.preventDefault(); });
14- var dailylink = dailyBuildsTab.get('boundingBox').one('a');
15- var releaselink = releaseBuildsTab.get('boundingBox').one('a');
16- dailylink.setStyle('color', 'grey');
17- releaselink.setStyle('color', 'grey');
18- dailylink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=mtidaily');
19- releaselink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=mtirelease');
20- }
21 if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-ti-restricted')) {
22 var restrictedBuildsTab = mti_tabview.item(2);
23 restrictedBuildsTab.on('click', function (e) { e.preventDefault(); });
24@@ -133,18 +120,6 @@
25 mste_tabview.on(
26 'render',
27 function (e) {
28- if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-ste')) {
29- var dailyBuildsTab = mste_tabview.item(0);
30- var releaseBuildsTab = mste_tabview.item(1);
31- dailyBuildsTab.on('click', function (e) { e.preventDefault(); });
32- releaseBuildsTab.on('click', function (e) { e.preventDefault(); });
33- var dailylink = dailyBuildsTab.get('boundingBox').one('a');
34- var releaselink = releaseBuildsTab.get('boundingBox').one('a');
35- dailylink.setStyle('color', 'grey');
36- releaselink.setStyle('color', 'grey');
37- dailylink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=mstedaily');
38- releaselink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=msterelease');
39- }
40 if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-ste-restricted')) {
41 var restrictedBuildsTab = mste_tabview.item(2);
42 restrictedBuildsTab.on('click', function (e) { e.preventDefault(); });
43@@ -157,18 +132,6 @@
44 msamsung_tabview.on(
45 'render',
46 function (e) {
47- if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-samsung')) {
48- var dailyBuildsTab = msamsung_tabview.item(0);
49- var releaseBuildsTab = msamsung_tabview.item(1);
50- dailyBuildsTab.on('click', function (e) { e.preventDefault(); });
51- releaseBuildsTab.on('click', function (e) { e.preventDefault(); });
52- var dailylink = dailyBuildsTab.get('boundingBox').one('a');
53- var releaselink = releaseBuildsTab.get('boundingBox').one('a');
54- dailylink.setStyle('color', 'grey');
55- releaselink.setStyle('color', 'grey');
56- dailylink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=msamsungdaily');
57- releaselink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=msamsungrelease');
58- }
59 if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-samsung-restricted')) {
60 var restrictedBuildsTab = msamsung_tabview.item(2);
61 restrictedBuildsTab.on('click', function (e) { e.preventDefault(); });
62@@ -181,18 +144,6 @@
63 marm_tabview.on(
64 'render',
65 function (e) {
66- if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-arm')) {
67- var dailyBuildsTab = marm_tabview.item(0);
68- var releaseBuildsTab = marm_tabview.item(1);
69- dailyBuildsTab.on('click', function (e) { e.preventDefault(); });
70- releaseBuildsTab.on('click', function (e) { e.preventDefault(); });
71- var dailylink = dailyBuildsTab.get('boundingBox').one('a');
72- var releaselink = releaseBuildsTab.get('boundingBox').one('a');
73- dailylink.setStyle('color', 'grey');
74- releaselink.setStyle('color', 'grey');
75- dailylink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=marmdaily');
76- releaselink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=marmrelease');
77- }
78 if (!globalConfig.userName || !in_array(groupsArray, 'linaro-android-member-arm-restricted')) {
79 var restrictedBuildsTab = marm_tabview.item(2);
80 restrictedBuildsTab.on('click', function (e) { e.preventDefault(); });
81@@ -212,13 +163,6 @@
82 userlink.setStyle('color', 'grey');
83 userlink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=user');
84 }
85- if (!globalConfig.userName || !globalConfig.userGroups.search(/member/)) {
86- var memberBuildsTab = team_tabview.item(1);
87- memberBuildsTab.on('click', function (e) { e.preventDefault(); });
88- var memberlink = memberBuildsTab.get('boundingBox').one('a');
89- memberlink.setStyle('color', 'grey');
90- memberlink.setAttribute('href', globalConfig.loginURL + '?next=' + location.pathname + '%23teams=member');
91- }
92 });
93
94 if ((history.get('teams') == 'user' && !globalConfig.userName) ||
95@@ -405,7 +349,7 @@
96 function (item) {
97 var group = 'linaro-android-member-ti';
98 var pattern = new RegExp("^~" + group + "\/(?!.*release).*$");
99- return (item.getValue('name').search(pattern) == 0 && in_array(groupsArray, group));
100+ return item.getValue('name').search(pattern) == 0;
101 }),
102 makeDT(
103 "#member-ti-release-build-table",
104@@ -422,7 +366,7 @@
105 function (item) {
106 var group = 'linaro-android-member-samsung';
107 var pattern = new RegExp("^~" + group + "\/(?!.*release).*$");
108- return (item.getValue('name').search(pattern) == 0 && in_array(groupsArray, group));
109+ return item.getValue('name').search(pattern) == 0;
110 }),
111 makeDT(
112 "#member-samsung-release-build-table",
113@@ -439,7 +383,7 @@
114 function (item) {
115 var group = 'linaro-android-member-arm';
116 var pattern = new RegExp("^~" + group + "\/(?!.*release).*$");
117- return (item.getValue('name').search(pattern) == 0 && in_array(groupsArray, group));
118+ return item.getValue('name').search(pattern) == 0;
119 }),
120 makeDT(
121 "#member-arm-release-build-table",
122@@ -456,7 +400,7 @@
123 function (item) {
124 var group = 'linaro-android-member-ste';
125 var pattern = new RegExp("^~" + group + "\/(?!.*release).*$");
126- return (item.getValue('name').search(pattern) == 0 && in_array(groupsArray, group));
127+ return item.getValue('name').search(pattern) == 0;
128 }),
129 makeDT(
130 "#member-ste-release-build-table",

Subscribers

People subscribed via source and target branches