Merge lp:~gesha/linaro-android-frontend/job-details-downloads-list-fix into lp:linaro-android-frontend

Proposed by Paul Sokolovsky
Status: Rejected
Rejected by: Paul Sokolovsky
Proposed branch: lp:~gesha/linaro-android-frontend/job-details-downloads-list-fix
Merge into: lp:linaro-android-frontend
Diff against target: 17 lines (+7/-0)
1 file modified
static/buildDetails.js (+7/-0)
To merge this branch: bzr merge lp:~gesha/linaro-android-frontend/job-details-downloads-list-fix
Reviewer Review Type Date Requested Status
Linaro Infrastructure Pending
Review via email: mp+102370@code.launchpad.net

Description of the change

Fix breakage on build details page for private builds.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Test shows that Content-Type returned is "text/html; charset=utf-8".

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Ok, fixed version has been committed and deployed.

Unmerged revisions

256. By Georgy Redkozubov

Downloads list fix on job details page

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/buildDetails.js'
2--- static/buildDetails.js 2012-02-10 18:11:54 +0000
3+++ static/buildDetails.js 2012-04-17 18:43:38 +0000
4@@ -255,6 +255,13 @@
5
6 if (io_result.status == 200)
7 {
8+ var contentType = io_result.getResponseHeader('Content-Type');
9+
10+ if (contentType == 'text/html')
11+ {
12+ return;
13+ }
14+
15 var manifest = io_result.responseText.split("\n");
16
17 var listNode = Y.Node.create('<ul/>');

Subscribers

People subscribed via source and target branches