Merge lp:~gesha/linaro-android-frontend/fix-scrolling into lp:linaro-android-frontend

Proposed by Georgy Redkozubov
Status: Merged
Approved by: Milo Casagrande
Approved revision: 296
Merged at revision: 296
Proposed branch: lp:~gesha/linaro-android-frontend/fix-scrolling
Merge into: lp:linaro-android-frontend
Diff against target: 25 lines (+15/-0)
1 file modified
static/index.js (+15/-0)
To merge this branch: bzr merge lp:~gesha/linaro-android-frontend/fix-scrolling
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+143079@code.launchpad.net

Description of the change

This branch adds lost code during previous merge. This should enable clicks on builds and fix bug #1097186.

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Seems good to me. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'static/index.js'
2--- static/index.js 2012-12-26 07:59:57 +0000
3+++ static/index.js 2013-01-14 11:17:19 +0000
4@@ -324,6 +324,21 @@
5
6 dt.render(id);
7
8+ dt.after(
9+ 'recordsetChange',
10+ function (e) {
11+ var rows = e.target.get('contentBox').all('tbody tr');
12+
13+ // there must be better ways to do this...
14+ rows.on(
15+ 'click',
16+ function (e) {
17+ var buildName = e.target.ancestor('tr').all('td').item(1).get('text');
18+ location.href = 'builds/'+buildName + '/';
19+ });
20+ }
21+ );
22+
23 var tableNode = Y.one(id);
24
25 var selectNode = tableNode.ancestor('div').one('select');

Subscribers

People subscribed via source and target branches