Merge lp:~gesha/linaro-android-frontend/build-details into lp:linaro-android-frontend

Proposed by Georgy Redkozubov
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 253
Merged at revision: 249
Proposed branch: lp:~gesha/linaro-android-frontend/build-details
Merge into: lp:linaro-android-frontend
Diff against target: 56 lines (+10/-7)
2 files modified
android_build/templates/buildDetails.html (+9/-7)
static/buildDetails.js (+1/-0)
To merge this branch: bzr merge lp:~gesha/linaro-android-frontend/build-details
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+92537@code.launchpad.net

Description of the change

Add a header to the list of builds, specify build number for which details are shown, style change to be more user friendly.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'android_build/templates/buildDetails.html'
2--- android_build/templates/buildDetails.html 2011-10-25 17:47:54 +0000
3+++ android_build/templates/buildDetails.html 2012-02-10 17:42:09 +0000
4@@ -6,7 +6,7 @@
5 <script type="text/javascript" src="{{MEDIA_URL}}buildDetails.js"></script>
6 {% endblock %}
7 {% block content %}
8-<h2>Build Details</h2>
9+<h2>Job Details</h2>
10 <div class="build-found hidden">
11 <p>
12 <b>Name:</b> {{ buildName }}
13@@ -21,7 +21,7 @@
14 <p id="job-description">
15 </p>
16 <p id="built-daily-details" class="hidden">
17- This build is <span id="not-built-daily" class="hidden">not</span>
18+ This job is <span id="not-built-daily" class="hidden">not</span>
19 built daily.
20 {% if canEdit %}
21 <input id="toggle-daily" type="button" value="change" />
22@@ -37,15 +37,17 @@
23 </dd>
24 </dl>
25 <div id="build-details" style="display: none">
26+ <h3>List of builds</h3>
27 <p>
28 <span id="olderlinks"></span>
29 </p>
30+ <h3>Details for build #<span id="buildnumber"></span></h3>
31 <p>
32- <b id="status"></b>
33- <br />
34- <b>Started:</b> <span id="started"></span>
35- <br />
36- <b>Finished:</b> <span id="finished"></span>
37+ Status: <b id="status"></b>
38+ <br />
39+ Started: <span id="started"></span>
40+ <br />
41+ Finished: <span id="finished"></span>
42 </p>
43 <dl>
44 <dt>
45
46=== modified file 'static/buildDetails.js'
47--- static/buildDetails.js 2012-01-24 14:38:42 +0000
48+++ static/buildDetails.js 2012-02-10 17:42:09 +0000
49@@ -306,6 +306,7 @@
50 }
51 Y.one("#olderlinks").get('childNodes').remove();
52 Y.one("#olderlinks").appendChild(olderlinks(results.number));
53+ Y.one("#buildnumber").setContent(results.number);
54 }
55
56 function olderlinks (curNumber) {

Subscribers

People subscribed via source and target branches