Merge lp:~gero-bare/switchboard/bug-1528361 into lp:~elementary-pantheon/switchboard/switchboard

[Gero.Bare]

Lower Idle.add priority in SwitchboardApp.load_plug due to a timing issue

Lower Idle.add priority in SwitchboardApp.load_plug due a timing issue.

Apparently the app crash due a pthreaad mutex.
This more an workaround than a proper fix, which would be reduce the
work of the function inside of the Idle.add
and limit it only to the critical section. (what it needs, no more no less).

In the other hand this should be fine, but at expense of the speed of the plug display. :(

[Danielle Foré (danrabbit)]

While I can confirm this solution works, I'd prefer to have a solution that doesn't show the home screen for a second. That's a bit janky. I think in order to award the bounty it should be for the proper fix instead of a workaround.

[Danielle Foré (danrabbit)]

As much as I want to insulate switchboard from a potential crash, this seems to add a pause to every pane, regardless of whether or not it is needed. So all the native plugs no longer load directly to the page.

review: Needs Fixing

[Gero.Bare (gero-bare)]

I tried but this is as far I can go on switchboard side.

I hope this can be fixed in the plug side (gcc specifically). But that is beyond my knowledge.

Thanks for the review.

[Danielle Foré (danrabbit)]

This seems to work without causing any regression, but Felipe would like to try something else before we merge. So, giving him just a bit of time :)

review: Approve

=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala	2016-02-07 16:08:57 +0000
+++ src/Switchboard.vala	2016-04-10 19:59:39 +0000
@@ -197,17 +197,27 @@
                 });
 
                 previous_plugs.add (plug);
-
-                // Launch plug's executable
-                navigation_button.set_sensitive (true);
-                navigation_button.set_text (all_settings_label);
-                navigation_button.show ();
-                headerbar.title = plug.display_name;
-                current_plug = plug;
+                return false;
+            });
+
+            // Launch plug's executable
+            navigation_button.set_sensitive (true);
+            navigation_button.set_text (all_settings_label);
+            navigation_button.show ();
+            headerbar.title = plug.display_name;
+            current_plug = plug;
+
+            //FIXME lower priority for gcc plugs due crash bug #1528361
+            var priority = GLib.Priority.DEFAULT_IDLE;
+            if (plug.code_name.contains ("-gcc-")) {
+                priority = GLib.Priority.LOW;
+            }
+
+            Idle.add (()=> {
                 switch_to_plug (plug);
-
                 return false;
-            });
+            }, priority);
+
         }
 
 #if HAVE_UNITY