Merge lp:~gero-bare/scratch/fix-1472377 into lp:~elementary-apps/scratch/scratch

[Gero.Bare]

Move tab to new window from main loop (lp:1472377)

[The Lemon Man (lemonboy)]

Code-wise LGTM, I'd just add a short comment explaining why it's being done in the main thread.

review: Approve (code)

[lp:~gero-bare/scratch/fix-1472377]

1588. By Gero.Bare on 2015-11-09

Rework in the critical section.

1589. By Gero.Bare on 2015-11-09

Minor change.

1590. By Gero.Bare on 2015-11-09

Correcting the comment.

1591. By Gero.Bare on 2015-11-09

Some style fixes.

Unmerged revisions

=== modified file 'src/Widgets/DocumentView.vala'
--- src/Widgets/DocumentView.vala	2015-10-29 23:03:09 +0000
+++ src/Widgets/DocumentView.vala	2015-11-09 21:22:02 +0000
@@ -249,8 +249,13 @@
 
             DocumentView other_view = other_window.add_view ();
 
-            this.notebook.remove_tab (doc);
-            other_view.notebook.insert_tab (doc, -1);
+            //We need to make sure switch back to the main thread
+            //when we are modifiying Gtk widgets shared by two threads.
+            Idle.add (() => {
+                this.notebook.remove_tab (doc);
+                other_view.notebook.insert_tab (doc, -1);
+                return false;
+            });
         }
 
         private void on_doc_reordered (Granite.Widgets.Tab tab, int new_pos) {