Midori Web Browser

Merge lp:~gero-bare/midori/midori-build-fix into lp:midori

  1. midori-build-fix
  2. Merge into trunk
Proposed by Gero.Bare
Status: Merged
Approved by: Cris Dywan
Approved revision: 6826
Merged at revision: 6827
Proposed branch: lp:~gero-bare/midori/midori-build-fix
Merge into: lp:midori
Diff against target: 12 lines (+1/-1)
1 file modified
midori/midori-panedaction.vala (+1/-1)
To merge this branch: bzr merge lp:~gero-bare/midori/midori-build-fix
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+240779@code.launchpad.net

Commit message

Build-fix: Make PanedAction's Child.widget public

Description of the change

Fix a Vala error to build midori.

The modifier protected is changed to public.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Newer Vala? Whilst I don't see a build error, this doesn't seem to break anything, and it's a private struct anyway, so no reason not to change it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-panedaction.vala'
2--- midori/midori-panedaction.vala 2012-05-27 13:08:23 +0000
3+++ midori/midori-panedaction.vala 2014-11-05 21:16:56 +0000
4@@ -17,7 +17,7 @@
5 Child child2 = new Child();
6
7 private struct Child {
8- protected Gtk.Widget widget;
9+ public Gtk.Widget widget;
10 string name;
11 bool resize;
12 bool shrink;

Subscribers

People subscribed via source and target branches

to all changes: