Midori Web Browser

Merge lp:~gero-bare/midori/midori-bug-820735 into lp:midori

  1. midori-bug-820735
  2. Merge into trunk
Proposed by Gero.Bare
Status: Merged
Approved by: Cris Dywan
Approved revision: 6848
Merged at revision: 6889
Proposed branch: lp:~gero-bare/midori/midori-bug-820735
Merge into: lp:midori
Diff against target: 14 lines (+4/-0)
1 file modified
midori/midori-browser.c (+4/-0)
To merge this branch: bzr merge lp:~gero-bare/midori/midori-bug-820735
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+243490@code.launchpad.net

Commit message

Don't add failed pages to history

Description of the change

Add check to verify if the page is loaded correctly, if there's a network error the url is not saved in the history.

To post a comment you must log in.
lp:~gero-bare/midori/midori-bug-820735 updated
6847. By Gero.Bare

Merge with midori.

6848. By Gero.Bare

Prevent to save to the history pages that fail to load.

Revision history for this message
Cris Dywan (kalikiana) wrote :

Nice! Thanks a lot!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-browser.c'
2--- midori/midori-browser.c 2014-11-22 17:20:43 +0000
3+++ midori/midori-browser.c 2015-02-13 00:57:15 +0000
4@@ -765,6 +765,10 @@
5 if (midori_uri_is_blank (proxy_uri))
6 return;
7
8+ //Do not save pages that fail to load in the history
9+ if (midori_tab_get_load_error (MIDORI_TAB (view)) == MIDORI_LOAD_ERROR_NETWORK)
10+ return;
11+
12 const gchar* history_step = katze_item_get_meta_string (proxy, "history-step");
13 if (history_step == NULL)
14 {

Subscribers

People subscribed via source and target branches

to all changes: