Merge lp:~gerboland/unity8/sidestage-handle-input-area into lp:unity8

[Gerry Boland]

Add InputFilterArea to sidestage handle to block input to mainstage app while moving sidestage

Add InputFilterArea to sidestage handle to block input to mainstage app while moving sidestage

• Are there any related MPs required for this MP to build/function as expected? Please list.
No
• Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
• If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
No

[Albert Astals Cid (aacid)]

Can we have a test for this?

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:675
http://jenkins.qa.ubuntu.com/job/unity8-ci/2208/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2839
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2587
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1081
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/730
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/732
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/732/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/730
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2487
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2841
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2841/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2588
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2588/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5015
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3561

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2208/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

> Can we have a test for this?
We have no automated test infrastructure for testing the use of InputAreas in place.

[Albert Astals Cid (aacid)]

Can't we have a qml test that has an Item with a MouseArea and then a SideStage on top and check that the Item's MouseArea doesn't get input?

[Gerry Boland (gerboland)]

Hmm, I had thought for Mir testing that input events were injected into the Qt event loop (so InputArea would not be interacted with), but in digging it looks like autopilot injects raw uevents. Ok, will look into test

[Gerry Boland (gerboland)]

> Hmm, I had thought for Mir testing that input events were injected into the Qt
> event loop (so InputArea would not be interacted with), but in digging it
> looks like autopilot injects raw uevents. Ok, will look into test
I'm talking rubbish. Shell always gets all events from uevent. What's important in this case is that it prevents those events being passed through to the focused application (which is what the InputArea specifies). So to test this, I would need to write autopilot test to launch an application, and have that communicate to the test somehow that it does/doesn't receives events. That'll be half a days work, for something that we'll throw away once we use a QML compositor.

[Albert Astals Cid (aacid)]

Why will we throw away the test? Isn't it important that we still test this bug is not present when using the QML compositor?

[Albert Astals Cid (aacid)]

Ok, Gerry convinced me on IRC that this was not worth a test.

[Albert Astals Cid (aacid)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, fixes the problem

 * Did CI run pass? If not, please explain why.
No, failed in unrelated network tests

review: Approve

=== modified file 'qml/SideStage/SideStage.qml'
--- qml/SideStage/SideStage.qml	2013-09-04 13:42:27 +0000
+++ qml/SideStage/SideStage.qml	2014-02-03 13:32:35 +0000
@@ -65,4 +65,9 @@
         Behavior on width { NumberAnimation { easing.type: Easing.OutQuart} }
         z: -1
     }
+
+    InputFilterArea {
+        anchors.fill: handle
+        blockInput: visible
+    }
 }