Merge lp:~gerboland/unity8/fix-sidestage into lp:unity8

[Gerry Boland]

Fix sidestage applications - they were being ignored in the show-application-surface logic

[Gerry Boland (gerboland)]

Whole Stage mechanism missing tests, so I didn't try

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:244
http://jenkins.qa.ubuntu.com/job/unity8-ci/781/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2644
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/271
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/782
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/782/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/781
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2650
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2650/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2239
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/273
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/273/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/244
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/247

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/781/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Works

review: Approve

=== modified file 'Shell.qml'
--- Shell.qml	2013-08-21 02:13:56 +0000
+++ Shell.qml	2013-08-26 21:03:28 +0000
@@ -161,10 +161,14 @@
         // Whether the underlay is fully covered by opaque UI elements.
         property bool fullyCovered: panel.indicators.fullyOpened && shell.width <= panel.indicatorsMenuWidth
 
+        readonly property bool applicationRunning: ((mainStage.applications && mainStage.applications.count > 0)
+                                           || (sideStage.applications && sideStage.applications.count > 0))
+
         // Whether the user should see the topmost application surface (if there's one at all).
-        property bool applicationSurfaceShouldBeSeen:
-                (mainStage.applications && mainStage.applications.count > 0)
-                && (!stages.fullyHidden && !mainStage.usingScreenshots)
+        readonly property bool applicationSurfaceShouldBeSeen: applicationRunning && !stages.fullyHidden
+                                           && !mainStage.usingScreenshots // but want sideStage animating over app surface
+
+
 
         // NB! Application surfaces are stacked behing the shell one. So they can only be seen by the user
         // through the translucent parts of the shell surface.