Code review comment for lp:~gerboland/unity-mir/use-upstart-app-launch2
| Gerry Boland (gerboland) wrote : | # |
© 2004-2021
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
r26785e5
(Get the code!)
> It's rather wasteful to parse a desktop file twice in this situation. Can't we
> easily avoid it by having a second constructor that takes a DesktopFileReader
> instead of a appId as an argument?
You raise a fair point. I wanted to avoid having to parse desktop files in ApplicationManager at all, delegating it to Application alone, but the authorizer forced my hand.
I did the duplicate as I hope much of that authorizer code will go away soon. But I'll try to improve it now.