Merge lp:~gerboland/unity-mir/use-shell-name into lp:unity-mir

Proposed by Gerry Boland
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 44
Merged at revision: 46
Proposed branch: lp:~gerboland/unity-mir/use-shell-name
Merge into: lp:unity-mir
Diff against target: 12 lines (+1/-1)
1 file modified
src/unity-mir/surfacebuilder.cpp (+1/-1)
To merge this branch: bzr merge lp:~gerboland/unity-mir/use-shell-name
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+181017@code.launchpad.net

Commit message

As qtubuntu setting surface title correctly, update shell surface detection criterion to suit

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Makes sense, i agree with your TODO though :D

We should have some property the shell sets when starting in some object

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-mir/surfacebuilder.cpp'
2--- src/unity-mir/surfacebuilder.cpp 2013-08-12 11:12:48 +0000
3+++ src/unity-mir/surfacebuilder.cpp 2013-08-20 11:00:40 +0000
4@@ -44,7 +44,7 @@
5 static const ms::DepthId shellSurfaceDepth{1};
6 static bool shellSurfaceFound = false;
7
8- if (params.name == "Window 1" && !shellSurfaceFound) //TODO(greyback) Mir should identify shell surface somehow
9+ if (params.name == "Qml Phone Shell" && !shellSurfaceFound) //TODO(greyback) Need to identify shell surface more securely
10 {
11 DLOG("Shell depth");
12 auto newParams = params;

Subscribers

People subscribed via source and target branches