unity-mir

Merge lp:~gerboland/unity-mir/qml-plugin-not-lib into lp:unity-mir

  1. qml-plugin-not-lib
  2. Merge into trunk
Proposed by Gerry Boland
Status: Merged
Approved by: Michał Sawicz
Approved revision: 155
Merged at revision: 156
Proposed branch: lp:~gerboland/unity-mir/qml-plugin-not-lib
Merge into: lp:unity-mir
Diff against target: 12 lines (+1/-1)
1 file modified
src/modules/Unity/Application/Application.pro (+1/-1)
To merge this branch: bzr merge lp:~gerboland/unity-mir/qml-plugin-not-lib
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michał Sawicz Approve
Review via email: mp+197121@code.launchpad.net

Commit message

Unity.Application is not a shared library, but a plugin.

Description of the change

Unity.Application is not a shared library, but a plugin.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:155
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/173/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/36/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/173/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Shouldn't this be TEMPLATE=plugin instead?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

Ok, not. Works!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/modules/Unity/Application/Application.pro'
2--- src/modules/Unity/Application/Application.pro 2013-10-09 15:24:16 +0000
3+++ src/modules/Unity/Application/Application.pro 2013-11-28 21:11:24 +0000
4@@ -2,7 +2,7 @@
5 TEMPLATE = lib
6
7 QT += core quick dbus
8-CONFIG += link_pkgconfig
9+CONFIG += link_pkgconfig plugin
10
11 # CONFIG += c++11 # only enables C++0x
12 QMAKE_CXXFLAGS = -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden

Subscribers

People subscribed via source and target branches