Merge lp:~gerboland/unity-2d/shell-background-isolate into lp:~unity-2d-team/unity-2d/unity-2d-shell
Status: | Superseded |
---|---|
Proposed branch: | lp:~gerboland/unity-2d/shell-background-isolate |
Merge into: | lp:~unity-2d-team/unity-2d/unity-2d-shell |
Diff against target: |
207 lines (+117/-48) 3 files modified
shell/Shell.qml (+1/-1) shell/common/Background.qml (+109/-0) shell/dash/Dash.qml (+7/-47) |
To merge this branch: | bzr merge lp:~gerboland/unity-2d/shell-background-isolate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tiago Salem Herrmann (community) | Approve | ||
Albert Astals Cid (community) | Needs Fixing | ||
MichaĆ Sawicz | Pending | ||
Review via email: mp+90850@code.launchpad.net |
This proposal has been superseded by a proposal from 2012-02-12.
Description of the change
[shell] Change the Dash's Background into a standalone element.
Unmerged revisions
- 952. By Gerry Boland
-
Merge latest shell & fix conflicts
- 951. By Gerry Boland
-
Update to trunk
- 950. By Gerry Boland
-
Remove unnecessary anchors.fill from Background.qml
- 949. By Gerry Boland
-
Add property to Background describing the border thicknesses. Use this to
specify the mergins needed in Dash.qml.Thanks to Albert for this advice in MR.
- 948. By Gerry Boland
-
Dash gives Background it's position so it draws the right blurred background
- 947. By Gerry Boland
-
Coordinates of background to blur must be manually specified. Fix state typos.
- 946. By Gerry Boland
-
Use states to control desktop/fullscreen modes.
- 945. By Gerry Boland
-
[shell] Change the Dash's Background into a standalone element.
You have
backgrounds.fill: parent
in two places that do the same, the Background item in Dash.qml and the root Item in Background.qml, not that it really matters, but maybe makes sense just having it in one place?
I'm a bit more concerned about the 39, 37 and 0, 0 for the margins when previously we just used content. anchors. bottomMargin and content. anchors. rightMargin, wouldn't it be better to introduce a property so you can assign it that way too?