Merge lp:~gerboland/unity-2d/alt+f2-remove-filtering-option into lp:unity-2d

Proposed by Gerry Boland
Status: Merged
Approved by: Michał Sawicz
Approved revision: 753
Merged at revision: 753
Proposed branch: lp:~gerboland/unity-2d/alt+f2-remove-filtering-option
Merge into: lp:unity-2d
Diff against target: 14 lines (+2/-2)
1 file modified
places/dash.qml (+2/-2)
To merge this branch: bzr merge lp:~gerboland/unity-2d/alt+f2-remove-filtering-option
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Alberto Mardegan Pending
Review via email: mp+78853@code.launchpad.net

Description of the change

[dash] Remove "Filter results" option from Alt+F2 run lens. Fix bug:838127

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

I'd rather a way to determine if a lens support filtering, and if not hide the button, but this should do for now.

Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'places/dash.qml'
2--- places/dash.qml 2011-09-27 09:09:55 +0000
3+++ places/dash.qml 2011-10-10 14:48:31 +0000
4@@ -239,8 +239,8 @@
5
6 KeyNavigation.left: search_entry
7
8- /* FilterPane is only to be displayed for lenses, not in the home page */
9- visible: dashView.activeLens != ""
10+ /* FilterPane is only to be displayed for lenses, not in the home page or Alt+F2 Run page */
11+ visible: dashView.activeLens != "" && dashView.activeLens != "commands.lens"
12 lens: visible && currentPage != undefined ? currentPage.model : undefined
13
14 anchors.top: search_entry.anchors.top

Subscribers

People subscribed via source and target branches