unity-2d

Merge lp:~gerboland/unity-2d/alt+f2-behaviour-fix into lp:unity-2d

  1. alt+f2-behaviour-fix
  2. Merge into trunk
Proposed by Gerry Boland
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 726
Merged at revision: 726
Proposed branch: lp:~gerboland/unity-2d/alt+f2-behaviour-fix
Merge into: lp:unity-2d
Diff against target: 11 lines (+1/-0)
1 file modified
places/dash.qml (+1/-0)
To merge this branch: bzr merge lp:~gerboland/unity-2d/alt+f2-behaviour-fix
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
Florian Boucault Pending
Review via email: mp+75738@code.launchpad.net

Description of the change

[dash] deactivateActiveLens failed to reset dashView.activeLens. This fixes Alt+F2 command lens behaviour reported in bug:847486 and bug:842413

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

I tested it, and it works fine. I also worked on the same bug, here's my branch:
https://code.launchpad.net/~mardy/unity-2d/alt-2f

But I like Gerry's fix better.

Revision history for this message
Alberto Mardegan (mardy) wrote :

Simple and working, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'places/dash.qml'
2--- places/dash.qml 2011-08-31 10:57:31 +0000
3+++ places/dash.qml 2011-09-16 14:05:25 +0000
4@@ -72,6 +72,7 @@
5 var lens = lenses.get(dashView.activeLens)
6 lens.active = false
7 }
8+ dashView.activeLens = ""
9 }
10
11 function activateLens(lensId) {

Subscribers

People subscribed via source and target branches