Merge lp:~gerboland/qtubuntu/window-close-support into lp:qtubuntu

Proposed by Gerry Boland on 2015-02-12
Status: Merged
Approved by: Nick Dedekind on 2015-06-17
Approved revision: 273
Merged at revision: 263
Proposed branch: lp:~gerboland/qtubuntu/window-close-support
Merge into: lp:qtubuntu
Prerequisite: lp:~mir-team/qtubuntu/port-to-mirclient
Diff against target: 13 lines (+3/-0)
1 file modified
src/ubuntumirclient/input.cpp (+3/-0)
To merge this branch: bzr merge lp:~gerboland/qtubuntu/window-close-support
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Needs Information on 2015-06-23
Robert Carr (community) 2015-02-12 Approve on 2015-02-17
PS Jenkins bot continuous-integration Needs Fixing on 2015-02-12
Review via email: mp+249579@code.launchpad.net

Commit message

Add support for Mir window close event

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Robert Carr (robertcarr) wrote :

+1

review: Approve
Nick Dedekind (nick-dedekind) wrote :

Looks fine to me.
Tested with qtmir close support and works fine.

review: Approve
Nick Dedekind (nick-dedekind) wrote :

It seems like the clients are re-creating their client windows after this event.

server log with mediator-report: http://pastebin.ubuntu.com/11761097/
client log with rpc-report: http://pastebin.ubuntu.com/11761104/

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntumirclient/input.cpp'
2--- src/ubuntumirclient/input.cpp 2015-02-12 22:14:29 +0000
3+++ src/ubuntumirclient/input.cpp 2015-02-12 22:14:29 +0000
4@@ -236,6 +236,9 @@
5 case mir_event_type_orientation:
6 dispatchOrientationEvent(ubuntuEvent->window->window(), mir_event_get_orientation_event(nativeEvent));
7 break;
8+ case mir_event_type_close_surface:
9+ QWindowSystemInterface::handleCloseEvent(ubuntuEvent->window->window());
10+ break;
11 default:
12 DLOG("unhandled event type: %d", static_cast<int>(mir_event_get_type(nativeEvent)));
13 }

Subscribers

People subscribed via source and target branches