Code review comment for lp:~gerboland/qtubuntu/fix_1351024

Revision history for this message
Gerry Boland (gerboland) wrote :

> // Use client geometry if set explicitly, use available screen geometry
> otherwise.
> d->geometry = window()->geometry() != screen->geometry() ?
> window()->geometry() : screen->availableGeometry();
>
>
> I would also move that to inside createWindow(), more specifically to here:
>
> } else {
> printf("UbuntuWindow - regular geometry\n");
> geometry = d->geometry;
> geometry.setY(d->panelHeight);
> }

That kind of refactoring is unnecessary for this bug fix, we can leave it for later.

« Back to merge proposal