Code review comment for lp:~gerboland/qtubuntu/fix_1351024
Revision history for this message
| Gerry Boland (gerboland) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
39bd251
(Get the code!)
Shouldn't we deduct panelHeight from the geometry.height?
Ie, it's either
(0, 0, screenWidth, screenHeight) or (0, panelHeight, screenWidth, screenHeight - panelHeight),
but here it seems you're setting it to (0, panelHeight, screenWidth, screenHeight), which is wrong
I disagree. The client is asking for a surface with a particular geometry, we should not shrink it. Shell is the one which decides to shrink it anyway