Code review comment for lp:~gerboland/qtubuntu/fix_1351024

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

     } else if (d->state == Qt::WindowMaximized) {
         printf("UbuntuWindow - maximized geometry\n");
         geometry = screen()->availableGeometry();
+ /*
+ * FIXME: Autopilot relies on being able to convert coordinates relative of the window
+ * into absolute screen coordinates. Mir does not allow this, see bug lp:1346633
+ * Until there's a correct way to perform this transformation agreed, this horrible hack
+ * guesses the transformation heuristically.
+ *
+ * Assumption: this method only used on phone devices!
+ */
+ geometry.setY(d->panelHeight);

Shouldn't we deduct panelHeight from the geometry.height?
Ie, it's either

(0, 0, screenWidth, screenHeight) or (0, panelHeight, screenWidth, screenHeight - panelHeight),
but here it seems you're setting it to (0, panelHeight, screenWidth, screenHeight), which is wrong

review: Needs Fixing

« Back to merge proposal