Merge lp:~gerboland/qtubuntu/fix-max-full-switch-size into lp:qtubuntu

Proposed by Gerry Boland on 2015-12-16
Status: Merged
Approved by: MichaƂ Sawicz on 2016-01-04
Approved revision: 302
Merged at revision: 302
Proposed branch: lp:~gerboland/qtubuntu/fix-max-full-switch-size
Merge into: lp:qtubuntu
Diff against target: 16 lines (+2/-0)
1 file modified
src/ubuntumirclient/window.cpp (+2/-0)
To merge this branch: bzr merge lp:~gerboland/qtubuntu/fix-max-full-switch-size
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-12-16
Daniel d'Andrada (community) code 2015-12-16 Approve on 2015-12-16
Review via email: mp+280699@code.launchpad.net

Commit Message

On geometry change, save new geometry before creating change event

To post a comment you must log in.
Daniel d'Andrada (dandrader) wrote :

I was tricked by QPlatformWindow::setGeometry documentation saying that calling that function wasn't neded. :/

review: Approve (code)
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntumirclient/window.cpp'
2--- src/ubuntumirclient/window.cpp 2015-12-07 16:20:58 +0000
3+++ src/ubuntumirclient/window.cpp 2015-12-16 11:29:46 +0000
4@@ -559,10 +559,12 @@
5 if (state == Qt::WindowFullScreen && geometry().y() != 0) {
6 QRect newGeometry = geometry();
7 newGeometry.setY(0);
8+ QPlatformWindow::setGeometry(newGeometry);
9 QWindowSystemInterface::handleGeometryChange(window(), newGeometry);
10 } else if (geometry().y() == 0) {
11 QRect newGeometry = geometry();
12 newGeometry.setY(panelHeight());
13+ QPlatformWindow::setGeometry(newGeometry);
14 QWindowSystemInterface::handleGeometryChange(window(), newGeometry);
15 }
16 }

Subscribers

People subscribed via source and target branches