Merge lp:~gerboland/qtubuntu/fix-ftbfs-mir0.25 into lp:qtubuntu

Proposed by Gerry Boland
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 363
Merged at revision: 361
Proposed branch: lp:~gerboland/qtubuntu/fix-ftbfs-mir0.25
Merge into: lp:qtubuntu
Diff against target: 65 lines (+11/-2)
3 files modified
debian/control (+1/-1)
src/ubuntumirclient/input.cpp (+9/-0)
src/ubuntumirclient/screen.h (+1/-1)
To merge this branch: bzr merge lp:~gerboland/qtubuntu/fix-ftbfs-mir0.25
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Unity8 CI Bot continuous-integration Approve
Albert Astals Cid (community) Approve
Review via email: mp+313525@code.launchpad.net

Commit message

Remove mircommon specifier for header, fix other ftbfs with mir 0.25

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

debugextension.cpp:22:39: fatal error: mir_toolkit/debug/surface.h: No such file or directory
 #include <mir_toolkit/debug/surface.h>

review: Needs Fixing
363. By Gerry Boland

[debian] Bump mirclient required version

Revision history for this message
Gerry Boland (gerboland) wrote :

You're missing libmirclient-debug-extension-dev

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good.

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:362
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/164/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3588
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3616
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3462/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3462/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3462/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3462/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3462/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3462
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3462/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/164/rebuild

review: Approve (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:363
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/166/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3671
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3699
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3541/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3541/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3541/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3541/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3541/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3541
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3541/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/166/rebuild

review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-09-22 19:45:30 +0000
3+++ debian/control 2016-12-19 10:24:12 +0000
4@@ -10,7 +10,7 @@
5 libgles2-mesa-dev,
6 libglib2.0-dev,
7 libinput-dev,
8- libmirclient-dev (>= 0.13.0),
9+ libmirclient-dev (>= 0.25.0),
10 libmirclient-debug-extension-dev,
11 libmtdev-dev,
12 libubuntu-application-api-dev (>= 2.9.0),
13
14=== modified file 'src/ubuntumirclient/input.cpp'
15--- src/ubuntumirclient/input.cpp 2016-11-04 13:24:35 +0000
16+++ src/ubuntumirclient/input.cpp 2016-12-19 10:24:12 +0000
17@@ -232,6 +232,8 @@
18 return "surface_output";
19 case mir_event_type_input_device_state:
20 return "input_device_state";
21+ case mir_event_type_surface_placement:
22+ return "surface_placement";
23 }
24 Q_UNREACHABLE();
25 }
26@@ -328,6 +330,8 @@
27 case mir_input_event_type_pointer:
28 dispatchPointerEvent(window, ev);
29 break;
30+ case mir_input_event_types:
31+ Q_UNREACHABLE();
32 }
33 }
34
35@@ -370,6 +374,9 @@
36 break;
37 case mir_touch_action_change:
38 touchPoint.state = Qt::TouchPointMoved;
39+ break;
40+ case mir_touch_actions:
41+ Q_UNREACHABLE();
42 }
43
44 touchPoints.append(touchPoint);
45@@ -530,6 +537,8 @@
46 case mir_pointer_action_leave:
47 QWindowSystemInterface::handleLeaveEvent(window);
48 break;
49+ case mir_pointer_actions:
50+ Q_UNREACHABLE();
51 }
52 }
53
54
55=== modified file 'src/ubuntumirclient/screen.h'
56--- src/ubuntumirclient/screen.h 2016-04-28 14:09:54 +0000
57+++ src/ubuntumirclient/screen.h 2016-12-19 10:24:12 +0000
58@@ -20,7 +20,7 @@
59 #include <qpa/qplatformscreen.h>
60 #include <QSurfaceFormat>
61
62-#include <mircommon/mir_toolkit/common.h> // just for MirFormFactor enum
63+#include <mir_toolkit/common.h> // just for MirFormFactor enum
64
65 #include "cursor.h"
66

Subscribers

People subscribed via source and target branches