Merge lp:~gerboland/qtubuntu/a11y into lp:qtubuntu

[Gerry Boland]

Enable Accessibility

Handiest way to test:

1. sudo systemctl stop lightdm
2. run sudo mir_demo_server --arw-file
3. in another VT, do following:

/usr/lib/at-spi2-core/at-spi-bus-launcher --launch-immediately
/usr/lib/at-spi2-core/at-spi2-registryd

This brings up the DBus server used by the A11Y framework.

4. In a third VT, install "accerciser" and run with:
MIR_SOCKET=/tmp/mir_socket python3 /usr/bin/accerciser
you should see it appear on screen.

Can double-check it works with "GDK_BACKEND=mir gedit" - accerciser allows you dig into the accessible portions of applications, which are used by screenreaders and other accessible technologies.

5. Now test Qt apps appear similarly in accerciser:
export QT_LINUX_ACCESSIBILITY_ALWAYS_ON=1 QT_ACCESSIBILITY=1

QT_DEBUG_ACCESSIBILITY=1 /usr/lib/x86_64-linux-gnu/qt5/examples/widgets/mainwindows/application/application

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:346
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/150/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/150/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:346
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/151/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3192
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3220
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3076/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3076
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3076/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/151/rebuild

review: Approve (continuous-integration)

[Nick Dedekind (nick-dedekind)]

Tested and works. Looks good from here.

review: Approve

[lp:~gerboland/qtubuntu/a11y]

347. By Gerry Boland on 2016-11-04

Merge trunk

348. By Gerry Boland on 2016-11-04

Stick to existing var naming standard

=== modified file 'src/ubuntumirclient/integration.cpp'
--- src/ubuntumirclient/integration.cpp	2016-10-04 16:20:07 +0000
+++ src/ubuntumirclient/integration.cpp	2016-11-04 15:14:33 +0000
@@ -39,6 +39,7 @@
 #include <QtPlatformSupport/private/qgenericunixfontdatabase_p.h>
 #include <QtPlatformSupport/private/qgenericunixeventdispatcher_p.h>
 #include <QtPlatformSupport/private/qeglpbuffer_p.h>
+#include <QtPlatformSupport/private/bridge_p.h>
 #include <QOpenGLContext>
 #include <QOffscreenSurface>
 
@@ -372,3 +373,11 @@
     QPlatformIntegration::destroyScreen(screen);
 #endif
 }
+
+QPlatformAccessibility *UbuntuClientIntegration::accessibility() const
+{
+    if (!mAccessibility) {
+        mAccessibility.reset(new QSpiAccessibleBridge());
+    }
+    return mAccessibility.data();
+}

=== modified file 'src/ubuntumirclient/integration.h'
--- src/ubuntumirclient/integration.h	2016-09-22 19:45:30 +0000
+++ src/ubuntumirclient/integration.h	2016-11-04 15:14:33 +0000
@@ -59,6 +59,7 @@
     QPlatformClipboard* clipboard() const override;
     void initialize() override;
     QPlatformOffscreenSurface *createPlatformOffscreenSurface(QOffscreenSurface *surface) const override;
+    QPlatformAccessibility *accessibility() const override;
 
     // New methods.
     MirConnection *mirConnection() const { return mMirConnection; }
@@ -83,6 +84,7 @@
 
     UbuntuInput* mInput;
     QPlatformInputContext* mInputContext;
+    mutable QScopedPointer<QPlatformAccessibility> mAccessibility;
     QScopedPointer<UbuntuDebugExtension> mDebugExtension;
     QScopedPointer<UbuntuScreenObserver> mScreenObserver;
     qreal mScaleFactor;