Merge lp:~gerboland/qtmir/multimonitorAPfix into lp:qtmir

Proposed by Gerry Boland on 2015-10-21
Status: Merged
Approved by: Daniel d'Andrada on 2015-10-21
Approved revision: 390
Merged at revision: 397
Proposed branch: lp:~gerboland/qtmir/multimonitorAPfix
Merge into: lp:qtmir
Prerequisite: lp:~dandrader/qtmir/multimonitorNext
Diff against target: 16 lines (+6/-0) (has conflicts)
1 file modified
src/platforms/mirserver/screencontroller.cpp (+6/-0)
Text conflict in src/platforms/mirserver/screenwindow.cpp
Text conflict in src/platforms/mirserver/screenwindow.h
Text conflict in tests/mirserver/Screen/screen_test.cpp
To merge this branch: bzr merge lp:~gerboland/qtmir/multimonitorAPfix
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Approve on 2015-10-21
PS Jenkins bot continuous-integration Needs Fixing on 2015-10-21
Lukáš Tinkl (community) 2015-10-21 Needs Information on 2015-10-21
Review via email: mp+275170@code.launchpad.net

Commit Message

Workaround for AutoPilot input coordinate positioning being outside screen geometry

To post a comment you must log in.
Lukáš Tinkl (lukas-kde) wrote :

Text conflict in src/platforms/mirserver/screenwindow.cpp
Text conflict in src/platforms/mirserver/screenwindow.h
Text conflict in tests/mirserver/Screen/screen_test.cpp

review: Needs Fixing
Lukáš Tinkl (lukas-kde) wrote :

Also, wouldn't QGuiApplication::topLevelAt() do basically the same thing as the whole method, preventing the bug?

review: Needs Information
Gerry Boland (gerboland) wrote :

Suspect LP confused, it merges cleanly for me

Daniel d'Andrada (dandrader) wrote :

Ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platforms/mirserver/screencontroller.cpp'
2--- src/platforms/mirserver/screencontroller.cpp 2015-10-21 11:36:07 +0000
3+++ src/platforms/mirserver/screencontroller.cpp 2015-10-21 11:36:07 +0000
4@@ -202,6 +202,12 @@
5
6 QWindow* ScreenController::getWindowForPoint(const QPoint &point) //FIXME - not thread safe & not efficient
7 {
8+ // This is a part optimization, and a part work-around for AP generated input events occasionally
9+ // appearing outside the screen borders: https://bugs.launchpad.net/qtmir/+bug/1508415
10+ if (m_screenList.length() == 1 && m_screenList.first()->window()) {
11+ return m_screenList.first()->window()->window();
12+ }
13+
14 for (Screen *screen : m_screenList) {
15 if (screen->window() && screen->geometry().contains(point)) {
16 return screen->window()->window();

Subscribers

People subscribed via source and target branches