lp:~gerboland/qtmir/frameSwapped-crash-fix
Created by
Gerry Boland
and last modified
- Get this branch:
- bzr branch lp:~gerboland/qtmir/frameSwapped-crash-fix
Only
Gerry Boland
can upload to this branch. If you are
Gerry Boland
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Daniel d'Andrada (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 91 lines (+25/-10)2 files modifiedsrc/modules/Unity/Application/mirsurfaceitem.cpp (+21/-10)
src/modules/Unity/Application/mirsurfaceitem.h (+4/-0)
Related bugs
Bug #1517571: Unity8 is crashing under UITK tests | Critical | Fix Released |
Related blueprints
Branch information
Recent revisions
- 413. By Gerry Boland
-
Manage frameSwapped signal/slot connection with MirSurface more strictly to avoid crash.
Direct Signal/slot connections across thread boundaries incur the same risks as any cross-thread calls. While connect/disconnect are thread safe methods, it is possible for a slot to be called while the slot owner is being deconstructed - and so not yet disconnected.
So watch for the Item's window change signal and disconnect signal immediately. Also move slot ownership to MirSurfaceItem to auto-disconnect more agressively.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:qtmir