lp:~gerboland/qtmir/fix-prompt-session-crash
Created by
Gerry Boland
and last modified
- Get this branch:
- bzr branch lp:~gerboland/qtmir/fix-prompt-session-crash
Only
Gerry Boland
can upload to this branch. If you are
Gerry Boland
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Unity8 CI Bot (community): Approve (continuous-integration)
- Daniel d'Andrada (community): Approve
- Albert Astals Cid (community): Abstain
-
Diff: 969 lines (+675/-84)13 files modifiedsrc/modules/Unity/Application/application_manager.h (+4/-2)
src/modules/Unity/Application/mirsurface.cpp (+0/-14)
src/modules/Unity/Application/mirsurface.h (+0/-1)
src/modules/Unity/Application/sessionmap_interface.h (+38/-0)
src/modules/Unity/Application/surfacemanager.cpp (+29/-4)
src/modules/Unity/Application/surfacemanager.h (+9/-2)
tests/framework/CMakeLists.txt (+3/-0)
tests/framework/mock_sessionmap.h (+32/-0)
tests/framework/mock_window_controller.h (+43/-0)
tests/modules/CMakeLists.txt (+2/-1)
tests/modules/SurfaceManager/CMakeLists.txt (+40/-0)
tests/modules/SurfaceManager/surface_manager_test.cpp (+475/-0)
tests/modules/WindowManager/mirsurface_test.cpp (+0/-60)
Related bugs
Related blueprints
Branch information
Recent revisions
- 621. By Gerry Boland
-
Actually include SurfaceManager tests. SM relies on AppMan singleton, which I had to abstract out to a SessionMap in order to make it testable.
- 620. By Gerry Boland
-
Stop MirSurface deleting itself, ensure SurfaceManager alone manages MirSurface lifetimes. Add SurfaceManager test suite.
This fixes bugs where a MirSurface would call deleteLater on itself, but SurfaceManager would have no idea and keep a pointer to that MirSurface in its internal list.
Instead SurfaceManager listens for signals from both miral and the MirSurface itself to decide when to delete it.
Add a test suite to verify MirSurface lifetimes.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:qtmir