lp:~gerboland/qtmir/RTM-fix-lifecycle-exempt-keeps-wakelock

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:qtmir/rtm-14.09 at revision 295

Albert Astals Cid (community): Approve on 2015-03-06

Gerry Boland (community): Abstain on 2015-03-06

Diff: 1184 lines (+653/-249)

15 files modified

debian/control (+2/-0)
src/common/abstractdbusservicemonitor.cpp (+2/-3)
src/common/abstractdbusservicemonitor.h (+1/-7)
src/modules/Unity/Application/Application.pro (+1/-1)
src/modules/Unity/Application/application.cpp (+3/-1)
src/modules/Unity/Application/application_manager.cpp (+5/-2)
src/modules/Unity/Application/sharedwakelock.cpp (+120/-57)
src/modules/Unity/Application/sharedwakelock.h (+14/-9)
tests/modules/Application/application_test.cpp (+7/-7)
tests/modules/ApplicationManager/application_manager_test.cpp (+78/-0)
tests/modules/SharedWakelock/SharedWakelock.pro (+11/-0)
tests/modules/SharedWakelock/sharedwakelock_test.cpp (+365/-146)
tests/modules/common/common.pri (+2/-1)
tests/modules/common/mock_shared_wakelock.h (+41/-14)
tests/modules/modules.pro (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1423787: music-app blocks system suspend even when not playing any song

High

Fix Released

Link a bug report

Related blueprints

301. By Gerry Boland on 2015-03-06

Racey test not so reliable, this helps

300. By Gerry Boland on 2015-03-06

Delete unnecesary line

299. By Gerry Boland on 2015-03-05

Fix and add test for SharedWakelock acq/rel/acq not loosing a cookie

298. By Gerry Boland on 2015-03-05

Fix acquire(), release(), acquire() being called in quick succession, and only after do 2 cookies get sent from dbus

297. By Gerry Boland on 2015-03-05

Refactor wakelock handling. Lifecycle exempt apps now release wakelock when shell tries to suspend them

The previous Wakelock RAII design was faulty as it was wrapping an asynchronous service. It made it possible for wakelocks to be acquired and not be released.

This refactors SharedWakelock to hold a single instance of Wakelock, and Wakelock always holds a DBus connection.

Testing now includes testing the DBus calls are actually emitted.

Adds dependency on libqtdbusmock1-dev and libqtdbustest1-dev

296. By Gerry Boland on 2015-02-27

Add test

295. By Gerry Boland on 2015-02-26

Lifecycle exempt apps now release wakelock when shell tries to suspend them

294. By Łukasz Zemczak on 2015-01-22

Releasing 0.4.4+15.04.20150121~rtm-0ubuntu1)

293. By Łukasz Zemczak on 2015-01-22

[ Gerry Boland ]
* Add Wakelock support - ensures device drops to deep-sleep mode only
  when all AppMan suspend tasks have completed (LP: #1309915)
[ Ricardo Mendoza ]
* Reduce suspend timeout to half of the previous value because the
  long value was too apparent on fast paced apps, like web games of
  music players; it broke the user experience according to design.
  (LP: #1402650)

292. By CI Train Bot Account on 2015-01-20

Releasing 0.4.4+15.04.20150120~rtm-0ubuntu1