Juju Charms Collection
stackmobile package

Merge lp:~george-edison55/charms/precise/stackmobile/added-icon into lp:charms/stackmobile

  1. Precise Pangolin (12.04)
  2. added-icon
  3. Merge into trunk
Proposed by Nathan Osman
Status: Merged
Merged at revision: 11
Proposed branch: lp:~george-edison55/charms/precise/stackmobile/added-icon
Merge into: lp:charms/stackmobile
Diff against target: 296 lines (+250/-8)
4 files modified
README.md (+6/-6)
config.yaml (+2/-2)
icon.svg (+240/-0)
metadata.yaml (+2/-0)
To merge this branch: bzr merge lp:~george-edison55/charms/precise/stackmobile/added-icon
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Kevin W Monroe Needs Fixing
Review via email: mp+183274@code.launchpad.net

Description of the change

I have made a couple of minor adjustments to this branch:

* added an icon
* switched from a plaintext README to Markdown

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Nathan, thanks for submitting this. The icon you've provided doesn't fit our requirements for an icon in the charm store. You can find the instructions and template in the docs: https://juju.ubuntu.com/docs/authors-charm-icon.html You're essentially there just need to have the "default" background to match the other charm icons in store.

Other than that, the rewrite of the README looks great, thanks for you patience, sorry it's taken so long to get to this reviewed!

review: Needs Fixing
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Finally, when you need another review, just "Request another review" from "charmers" and we'll respond a lot quicker next time.

Revision history for this message
Nathan Osman (george-edison55) wrote :

I've fixed up the icon (thanks for linking to the docs). Where am I looking for this "Request another review" button? Are you referring to the charmers group on Launchpad?

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

Hi Nathan - we've recently updated our review queue process and noticed this fell through the cracks months ago. Apologies! Your icon/readme updates look great, but charm proof reports a missing 'categories:' option in metadata.yaml. See the categories section for more info:

https://juju.ubuntu.com/docs/authors-charm-writing.html

'miscellaneous' seems appropriate here. We've moved this back to Work in Progress. Once you've updated metadata.yaml, please move to Needs Review again - that will automatically put this back onto the review queue. Thanks for your patience here.

review: Needs Fixing
Revision history for this message
Nathan Osman (george-edison55) wrote :

I've set the category to "miscellaneous" now.

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'README' => 'README.md'
2--- README 2012-03-29 19:39:32 +0000
3+++ README.md 2014-09-07 23:37:17 +0000
4@@ -2,16 +2,16 @@
5
6 1. Assuming you have a working installation of Juju, run the following commands:
7
8- > juju bootstrap
9- > juju deploy mysql
10- > juju deploy stackmobile
11- > juju add-relation stackmobile mysql
12+ juju bootstrap
13+ juju deploy mysql
14+ juju deploy stackmobile
15+ juju add-relation stackmobile mysql
16
17 2. Set the configuration parameters you would like to use for Stack Mobile.
18 (This currently only includes a single parameter: 'title'):
19
20- > juju set title="Site Title"
21+ juju set title="Site Title"
22
23 3. Expose the Stack Mobile instance:
24
25- > juju expose stackmobile
26+ juju expose stackmobile
27
28=== modified file 'config.yaml'
29--- config.yaml 2012-02-24 18:54:04 +0000
30+++ config.yaml 2014-09-07 23:37:17 +0000
31@@ -1,5 +1,5 @@
32 options:
33 title:
34- default: Untitled Site
35+ default: Stack Mobile
36 type: string
37- description: The name of the site (cannot be "Stack Mobile")
38+ description: The name of the site
39
40=== added file 'icon.svg'
41--- icon.svg 1970-01-01 00:00:00 +0000
42+++ icon.svg 2014-09-07 23:37:17 +0000
43@@ -0,0 +1,240 @@
44+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
45+<!-- Created with Inkscape (http://www.inkscape.org/) -->
46+
47+<svg
48+ xmlns:dc="http://purl.org/dc/elements/1.1/"
49+ xmlns:cc="http://creativecommons.org/ns#"
50+ xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
51+ xmlns:svg="http://www.w3.org/2000/svg"
52+ xmlns="http://www.w3.org/2000/svg"
53+ xmlns:xlink="http://www.w3.org/1999/xlink"
54+ version="1.1"
55+ width="96"
56+ height="96"
57+ id="svg6517">
58+ <defs
59+ id="defs6519">
60+ <linearGradient
61+ x1="0"
62+ y1="970.29498"
63+ x2="144"
64+ y2="970.29498"
65+ id="linearGradient6461"
66+ xlink:href="#Background"
67+ gradientUnits="userSpaceOnUse"
68+ gradientTransform="matrix(0,-0.66666669,0.6660448,0,-866.25992,731.29077)" />
69+ <linearGradient
70+ id="Background">
71+ <stop
72+ id="stop4178"
73+ style="stop-color:#58a1d4;stop-opacity:1"
74+ offset="0" />
75+ <stop
76+ id="stop4180"
77+ style="stop-color:#c7e0f1;stop-opacity:1"
78+ offset="1" />
79+ </linearGradient>
80+ <filter
81+ color-interpolation-filters="sRGB"
82+ id="filter1121">
83+ <feFlood
84+ id="feFlood1123"
85+ result="flood"
86+ flood-color="rgb(0,0,0)"
87+ flood-opacity="0.59999999999999998" />
88+ <feComposite
89+ in2="SourceGraphic"
90+ operator="out"
91+ in="flood"
92+ result="composite1"
93+ id="feComposite1125" />
94+ <feGaussianBlur
95+ id="feGaussianBlur1127"
96+ result="blur"
97+ stdDeviation="1"
98+ in="composite1" />
99+ <feOffset
100+ id="feOffset1129"
101+ result="offset"
102+ dy="2"
103+ dx="0" />
104+ <feComposite
105+ in2="SourceGraphic"
106+ operator="atop"
107+ in="offset"
108+ result="composite2"
109+ id="feComposite1131" />
110+ </filter>
111+ <filter
112+ color-interpolation-filters="sRGB"
113+ id="filter950">
114+ <feFlood
115+ id="feFlood952"
116+ result="flood"
117+ flood-color="rgb(0,0,0)"
118+ flood-opacity="0.25" />
119+ <feComposite
120+ in2="SourceGraphic"
121+ operator="in"
122+ in="flood"
123+ result="composite1"
124+ id="feComposite954" />
125+ <feGaussianBlur
126+ id="feGaussianBlur956"
127+ result="blur"
128+ stdDeviation="1"
129+ in="composite1" />
130+ <feOffset
131+ id="feOffset958"
132+ result="offset"
133+ dy="1"
134+ dx="0" />
135+ <feComposite
136+ in2="offset"
137+ operator="over"
138+ in="SourceGraphic"
139+ result="composite2"
140+ id="feComposite960" />
141+ </filter>
142+ <clipPath
143+ id="clipPath873">
144+ <g
145+ transform="matrix(0,-0.66666667,0.66604479,0,-258.25992,677.00001)"
146+ id="g875"
147+ style="fill:#ff00ff;fill-opacity:1;stroke:none;display:inline">
148+ <path
149+ d="m 46.702703,898.22775 50.594594,0 C 138.16216,898.22775 144,904.06497 144,944.92583 l 0,50.73846 c 0,40.86071 -5.83784,46.69791 -46.702703,46.69791 l -50.594594,0 C 5.8378378,1042.3622 0,1036.525 0,995.66429 l 0,-50.73846 c 0,-40.86086 5.8378378,-46.69808 46.702703,-46.69808 z"
150+ id="path877"
151+ style="fill:#ff00ff;fill-opacity:1;stroke:none;display:inline" />
152+ </g>
153+ </clipPath>
154+ <filter
155+ color-interpolation-filters="sRGB"
156+ id="filter891">
157+ <feGaussianBlur
158+ id="feGaussianBlur893"
159+ stdDeviation="0.71999962" />
160+ </filter>
161+ <filter
162+ color-interpolation-filters="sRGB"
163+ id="filter4140">
164+ <feFlood
165+ result="flood"
166+ flood-color="rgb(0,0,0)"
167+ flood-opacity="0.5"
168+ id="feFlood4142" />
169+ <feComposite
170+ in2="SourceGraphic"
171+ operator="in"
172+ in="flood"
173+ result="composite1"
174+ id="feComposite4144" />
175+ <feGaussianBlur
176+ result="blur"
177+ stdDeviation="1"
178+ id="feGaussianBlur4146" />
179+ <feOffset
180+ result="offset"
181+ dy="1"
182+ dx="1"
183+ id="feOffset4148" />
184+ <feComposite
185+ in2="offset"
186+ operator="over"
187+ in="SourceGraphic"
188+ result="composite2"
189+ id="feComposite4150" />
190+ </filter>
191+ </defs>
192+ <metadata
193+ id="metadata6522">
194+ <rdf:RDF>
195+ <cc:Work
196+ rdf:about="">
197+ <dc:format>image/svg+xml</dc:format>
198+ <dc:type
199+ rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
200+ <dc:title></dc:title>
201+ </cc:Work>
202+ </rdf:RDF>
203+ </metadata>
204+ <g
205+ transform="translate(268,-635.29076)"
206+ id="layer1"
207+ style="display:inline">
208+ <path
209+ d="m -268,700.15563 0,-33.72973 c 0,-27.24324 3.88785,-31.13513 31.10302,-31.13513 l 33.79408,0 c 27.21507,0 31.1029,3.89189 31.1029,31.13513 l 0,33.72973 c 0,27.24325 -3.88783,31.13514 -31.1029,31.13514 l -33.79408,0 c -27.21517,0 -31.10302,-3.89189 -31.10302,-31.13514 z"
210+ id="path6455"
211+ style="fill:url(#linearGradient6461);fill-opacity:1;stroke:none;display:inline;filter:url(#filter1121)" />
212+ </g>
213+ <g
214+ id="layer3"
215+ style="display:inline">
216+ <g
217+ transform="matrix(0.77323757,0,0,0.77323757,10.884597,-728.61055)"
218+ id="layer1-4"
219+ style="filter:url(#filter4140)">
220+ <rect
221+ width="79.296974"
222+ height="20.708128"
223+ x="8.3515053"
224+ y="966.48138"
225+ id="rect2985"
226+ style="fill:#ffffff;fill-opacity:1;fill-rule:evenodd;stroke:none" />
227+ <rect
228+ width="79.296974"
229+ height="20.708128"
230+ x="8.3515129"
231+ y="994.00806"
232+ id="rect2985-6"
233+ style="fill:#ffffff;fill-opacity:1;fill-rule:evenodd;stroke:none" />
234+ <rect
235+ width="79.296974"
236+ height="20.708128"
237+ x="8.3515205"
238+ y="1021.5348"
239+ id="rect2985-4"
240+ style="fill:#ffffff;fill-opacity:1;fill-rule:evenodd;stroke:none" />
241+ </g>
242+ </g>
243+ <g
244+ id="layer2"
245+ style="display:none">
246+ <g
247+ transform="translate(-340.00001,-581)"
248+ id="g4394"
249+ style="display:inline">
250+ <g
251+ id="g855">
252+ <g
253+ clip-path="url(#clipPath873)"
254+ id="g870"
255+ style="opacity:0.6;filter:url(#filter891)">
256+ <path
257+ d="m 264,552.36218 a 12,12 0 1 1 -24,0 12,12 0 1 1 24,0 z"
258+ transform="matrix(1.4999992,0,0,1.4999992,-29.999795,-237.54282)"
259+ id="path844"
260+ style="color:#000000;fill:#000000;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:4;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" />
261+ </g>
262+ <g
263+ id="g862">
264+ <path
265+ d="m 264,552.36218 a 12,12 0 1 1 -24,0 12,12 0 1 1 24,0 z"
266+ transform="matrix(1.4999992,0,0,1.4999992,-29.999795,-238.54282)"
267+ id="path4398"
268+ style="color:#000000;fill:#f5f5f5;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:4;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" />
269+ <path
270+ d="m 264,552.36218 a 12,12 0 1 1 -24,0 12,12 0 1 1 24,0 z"
271+ transform="matrix(1.25,0,0,1.25,33,-100.45273)"
272+ id="path4400"
273+ style="color:#000000;fill:#dd4814;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:4;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" />
274+ <path
275+ d="m 669.8173,595.77657 c -0.39132,0.22593 -3.62645,-1.90343 -4.07583,-1.95066 -0.44938,-0.0472 -4.05653,1.36297 -4.39232,1.06062 -0.3358,-0.30235 0.68963,-4.03715 0.59569,-4.47913 -0.0939,-0.44198 -2.5498,-3.43681 -2.36602,-3.8496 0.18379,-0.41279 4.05267,-0.59166 4.44398,-0.81759 0.39132,-0.22593 2.48067,-3.48704 2.93005,-3.4398 0.44938,0.0472 1.81505,3.67147 2.15084,3.97382 0.3358,0.30236 4.08294,1.2817 4.17689,1.72369 0.0939,0.44198 -2.9309,2.86076 -3.11469,3.27355 -0.18379,0.41279 0.0427,4.27917 -0.34859,4.5051 z"
276+ transform="matrix(1.511423,-0.16366377,0.16366377,1.511423,-755.37346,-191.93651)"
277+ id="path4459"
278+ style="color:#000000;fill:#f5f5f5;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:3;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" />
279+ </g>
280+ </g>
281+ </g>
282+ </g>
283+</svg>
284
285=== modified file 'metadata.yaml'
286--- metadata.yaml 2012-06-26 00:42:59 +0000
287+++ metadata.yaml 2014-09-07 23:37:17 +0000
288@@ -3,6 +3,8 @@
289 maintainer: Nathan Osman <admin@quickmediasolutions.com>
290 description: |
291 Stack Mobile provides a web-based interface to the content of the Stack Exchange network optimized for smartphones and tablets.
292+categories:
293+ - miscellaneous
294 provides:
295 website:
296 interface: http

Subscribers

People subscribed via source and target branches

to all changes: