Code review comment for lp:~genius12a/unity/unity
Revision history for this message
| Anish Dowlut (genius12a) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
On 06/28/2014 04:40 AM, Marco Trevisan (Treviño) wrote:
> Review: Disapprove
>
> I've another solution for this, more complex, but it's something I need to do ASAP... We still want these device and trash icons to be used to handle the file manager, but we don't want the nautilus icon to fight with them...
>
> So, for now I'd prefer to avoid this.
I do agree with you that the devices and trash icons could be better
used in Unity. I've noted that you've already started taking steps to
achieve this in bug #1063830, #1161323 and #75393. I understand that you
are still working on a perfect solution for the problem. However, since
the solution is not complete yet, the changes in behavior that you've
made to Unity does not seem correct at the moment (which is why bug
#1170647 was filed). Of course, the new behavior would make complete
sense once the whole solution has been delivered. But for now, I believe
it would be best if all changes were reverted until the complete
solution is available.
By the way, I have a few ideas that could help solving the whole problem
and may be I can help a bit with the code. Where is the right place to
discuss that?