Merge lp:ical-tcl into lp:~sergii/ical-tcl/main

Proposed by Guillaume Ballin
Status: Needs review
Proposed branch: lp:ical-tcl
Merge into: lp:~sergii/ical-tcl/main
Diff against target: 81 lines (+21/-3)
3 files modified
Makefile.am (+16/-1)
configure.ac (+1/-1)
dayview.tcl (+4/-1)
To merge this branch: bzr merge lp:ical-tcl
Reviewer Review Type Date Requested Status
Guillaume Ballin (community) Approve
Review via email: mp+365625@code.launchpad.net

Commit message

Adding a desktop file to ical and a modern color icon.
Update autotools files to avoid warnings.

To post a comment you must log in.
Revision history for this message
Guillaume Ballin (geballin) :
review: Approve
Revision history for this message
Sergei Golubchik (sergii) wrote :

I'm no longer using ical, or bzr fwiw.

Would you like to take over maintaining it?

Revision history for this message
Guillaume Ballin (geballin) wrote :

Hi,

I'm OK in maintaining it if that can make it continue to live and evolve.
I'm already actually the maintainer of the Arch linux package for iCal on AUR.

Revision history for this message
Sergei Golubchik (sergii) wrote :

Hi, Guillaume!

On Apr 09, Guillaume Ballin wrote:
> Hi,
>
> I'm OK in maintaining it if that can make it continue to live and evolve.
> I'm already actually the maintainer of the Arch linux package for iCal on AUR.

Here you are, you're the new maintainer.

Thanks!

Regards,
Sergei

lp:ical-tcl updated
47. By Guillaume Ballin

Merge for creating Ical 3.0.4
Adding ical.desktop and new modern icon.

Unmerged revisions

47. By Guillaume Ballin

Merge for creating Ical 3.0.4
Adding ical.desktop and new modern icon.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.am'
2--- Makefile.am 2017-02-23 09:11:34 +0000
3+++ Makefile.am 2019-04-13 01:05:11 +0000
4@@ -6,9 +6,10 @@
5 icallib_DATA = $(builddir)/startup.tcl $(builddir)/ps_header.tcl
6 EXTRA_DIST = startup.tcl.in ps_header.ps doc/ical.html doc/interface.html \
7 COPYRIGHT.ORIG Makefile.am
8-CLEANFILES = $(icallib_DATA)
9 dist_man1_MANS = doc/ical.man
10
11+appdir = $(prefix)/share/applications
12+app_DATA = ical.desktop
13 ical_SOURCES = cal_tcl.C dateeditor.C dispatch.C ical.C ical_tcl.C \
14 item_tcl.C object.C time_tcl.C main.C
15 ical_CPPFLAGS = -DICALLIBDIR='"$(icallibdir)"' -I$(srcdir)/calendar -I$(srcdir)/types -I$(srcdir)/time @TK_XINCLUDES@
16@@ -29,6 +30,8 @@
17
18 libtypes_a_SOURCES = types/bitvec.C types/hashfuncs.C types/intset.C
19
20+CLEANFILES = $(icallib_DATA) $(app_DATA)
21+
22 ps_header.tcl: ps_header.ps
23 echo 'proc ps_header {} { set val {}' > $@;
24 @SED@ -e 's/\[/\\[/g' \
25@@ -36,6 +39,18 @@
26 -e 's/.*/ set val "$$val&\\n"/' < $< >> $@;
27 echo ' return $$val\n}' >> $@
28
29+ical.desktop:
30+ echo "[Desktop Entry]" >$@
31+ echo "Name=Ical" >>$@
32+ echo "Comment=Ical calendar package" >>$@
33+ echo "Exec=ical" >>$@
34+ echo 'Icon=$(icallibdir)/contrib/ical_icon.png' >>$@
35+ echo "Terminal=false" >>$@
36+ echo "Type=Application" >>$@
37+ echo "Categories=Office" >>$@
38+ echo "StartupNotify=true;" >>$@
39+ chmod 644 $@
40+
41 # cannot do it in configure, as libdir is not known there :(
42 startup.tcl: startup.tcl.in
43 @SED@ -e 's!@''PACKAGE_VERSION''@!@PACKAGE_VERSION@!g' \
44
45=== modified file 'configure.ac'
46--- configure.ac 2018-02-11 11:25:00 +0000
47+++ configure.ac 2019-04-13 01:05:11 +0000
48@@ -1,5 +1,5 @@
49 AC_INIT([ical], [3.0.4])
50-AM_INIT_AUTOMAKE
51+AM_INIT_AUTOMAKE([subdir-objects])
52
53 # Create config files
54 AC_CONFIG_HEADER(config.h)
55
56=== added file 'contrib/ical_icon.png'
57Binary files contrib/ical_icon.png 1970-01-01 00:00:00 +0000 and contrib/ical_icon.png 2019-04-13 01:05:11 +0000 differ
58=== modified file 'dayview.tcl'
59--- dayview.tcl 2011-01-12 11:31:47 +0000
60+++ dayview.tcl 2019-04-13 01:05:11 +0000
61@@ -7,8 +7,10 @@
62 # A DayView shows the notices and appointments for one day.
63
64 set dayview_id 0
65+set ICAL_ICON [file join [file dirname [info script]] contrib ical_icon.png]
66
67 class DayView {} {
68+ global ICAL_ICON
69 # Generate new id for window
70 global dayview_id
71 incr dayview_id
72@@ -47,7 +49,8 @@
73
74 wm title $n Calendar
75 wm iconname $n ical
76- wm iconbitmap $n ical_icon
77+ image create photo applicationIcon -file $ICAL_ICON;wm iconphoto $n -default applicationIcon
78+
79 wm protocol $n WM_DELETE_WINDOW [list ical_close_view $n]
80
81 $self set_date [date today]

Subscribers

People subscribed via source and target branches