Merge lp:~gcollura/ubuntu-weather-app/fix-1297463 into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Giulio Collura on 2014-09-25
Status: Work in progress
Proposed branch: lp:~gcollura/ubuntu-weather-app/fix-1297463
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 13 lines (+2/-2)
1 file modified
ubuntu-weather-app.qml (+2/-2)
To merge this branch: bzr merge lp:~gcollura/ubuntu-weather-app/fix-1297463
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-01-14
Nicholas Skaggs (community) Needs Fixing on 2014-11-24
Alan Pope 🍺🐧🐱 πŸ¦„ Approve on 2014-09-27
Martin Borho 2014-09-25 Abstain on 2014-09-25
Review via email: mp+235937@code.launchpad.net

Commit message

Fix bug 1297463

Set the application to run with wide aspect on the desktop.

Description of the change

Fix bug 1297463 about app width on desktop.

To post a comment you must log in.
Martin Borho (martin-borho) wrote :

Hi Guilio,

thanks for the MP!

As the weather app uses the phone view as standard layout, it's not fortunate to set another initial size. https://bugs.launchpad.net/ubuntu-weather-app/+bug/1297463/comments/3

And I would not recommend to change the default layout from phone to tablet, since phone is the main focus at the moment. And a new design in the works.

Cheers
Martin

review: Abstain

Yeah, unfortunately this will cause issues when run on the device. If there was some way we could have two separate default sizes, that would be awesome. I don't know how you can do that though.

Looks good!

review: Approve

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~gcollura/ubuntu-weather-app/fix-1297463/+merge/235937/+edit-commit-message

review: Needs Fixing (continuous-integration)
Martin Borho (martin-borho) wrote :

Alan, the problem doesn't occur on the device anymore? And the gray font in the sidemenu?

Nicholas Skaggs (nskaggs) wrote :

Indeed, the width changes need to be conditional based upon screen size.

review: Needs Fixing
Giulio Collura (gcollura) wrote :

> Indeed, the width changes need to be conditional based upon screen size.
I'll work on that possibly during the weekend :)

Giulio

Unmerged revisions

372. By Giulio Collura on 2014-09-23

Fix bug #1297463

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-weather-app.qml'
2--- ubuntu-weather-app.qml 2014-09-20 10:55:31 +0000
3+++ ubuntu-weather-app.qml 2014-09-25 11:03:25 +0000
4@@ -32,8 +32,8 @@
5
6 id: mainView
7
8- width: units.gu(50)
9- height: units.gu(67)
10+ width: units.gu(100)
11+ height: units.gu(80)
12
13 useDeprecatedToolbar: false
14

Subscribers

People subscribed via source and target branches