Merge lp:~gcollura/ubuntu-calendar-app/fix-1401718 into lp:ubuntu-calendar-app

Proposed by Giulio Collura
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 565
Merged at revision: 564
Proposed branch: lp:~gcollura/ubuntu-calendar-app/fix-1401718
Merge into: lp:ubuntu-calendar-app
Diff against target: 12 lines (+1/-1)
1 file modified
click/manifest.json.in (+1/-1)
To merge this branch: bzr merge lp:~gcollura/ubuntu-calendar-app/fix-1401718
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Bartosz Kosiorek (community) Approve
Review via email: mp+245417@code.launchpad.net

Commit message

Update sdk version in manifest.json.in

Description of the change

Fix bug 1401718. Change default sdk version to non -dev.

To post a comment you must log in.
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Looks ok for me

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
565. By Giulio Collura

Run Jenkins again

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/446/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/549
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/549/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-autolanding/18

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/447/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/550
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/550/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-autolanding/19

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) :
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/manifest.json.in'
2--- click/manifest.json.in 2014-10-02 12:21:35 +0000
3+++ click/manifest.json.in 2014-12-29 11:19:09 +0000
4@@ -1,7 +1,7 @@
5 {
6 "architecture": "all",
7 "description": "A calendar for Ubuntu which syncs with online accounts",
8- "framework": "ubuntu-sdk-14.10-qml-dev3",
9+ "framework": "ubuntu-sdk-14.10-qml",
10 "hooks": {
11 "calendar": {
12 "account-application": "@PROJECT_NAME@_@APP_NAME@.application",

Subscribers

People subscribed via source and target branches

to status/vote changes: