Merge lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation into lp:ubuntu-calculator-app

Proposed by Giulio Collura on 2015-01-14
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„ on 2015-01-14
Approved revision: 62
Merged at revision: 61
Proposed branch: lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation
Merge into: lp:ubuntu-calculator-app
Diff against target: 23 lines (+2/-2)
2 files modified
app/ubuntu-calculator-app.qml (+1/-1)
manifest.json.in (+1/-1)
To merge this branch: bzr merge lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-01-14
Riccardo Padovani Approve on 2015-01-14
Alan Pope 🍺🐧🐱 πŸ¦„ 2015-01-14 Approve on 2015-01-14
Review via email: mp+246430@code.launchpad.net

Commit Message

Fix keyboard layout switching on device rotation broken at rev #48. Hardcode architecture to 'all'.

Description of the Change

I broke the keyboard rotation on the mobile device on rev #48. My bad. Here's a fix for that bug :)
Now if the device is rotated the keyboard successfully switch to landscape mode.

Edit: as requested by @popey, the architecture in manifest.json is now hardcoded to "all", since there's no binary in our package.

Thanks,
Giulio

To post a comment you must log in.
62. By Giulio Collura on 2015-01-14

hardcode architecture to 'all'

Riccardo Padovani (rpadovani) wrote :

Thanks Giulio!

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ubuntu-calculator-app.qml'
2--- app/ubuntu-calculator-app.qml 2015-01-09 17:27:52 +0000
3+++ app/ubuntu-calculator-app.qml 2015-01-14 15:02:27 +0000
4@@ -421,7 +421,7 @@
5 Loader {
6 id: keyboardLoader
7 width: parent.width
8- source: mainView.width > mainView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraiKeyboard.qml"
9+ source: scrollableView.width > scrollableView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraiKeyboard.qml"
10 opacity: ((y+height) >= scrollableView.contentY) && (y <= (scrollableView.contentY + scrollableView.height)) ? 1 : 0
11 }
12 }
13
14=== modified file 'manifest.json.in'
15--- manifest.json.in 2014-12-28 14:20:45 +0000
16+++ manifest.json.in 2015-01-14 15:02:27 +0000
17@@ -1,5 +1,5 @@
18 {
19- "architecture": "@CLICK_ARCH@",
20+ "architecture": "all",
21 "description": "description of ubuntu-calculator-app",
22 "framework": "ubuntu-sdk-14.10",
23 "hooks": {

Subscribers

People subscribed via source and target branches