Merge lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation into lp:ubuntu-calculator-app
Proposed by
Giulio Collura
on 2015-01-14
| Status: | Merged |
|---|---|
| Approved by: | Alan Pope πΊπ§π± π¦ on 2015-01-14 |
| Approved revision: | 62 |
| Merged at revision: | 61 |
| Proposed branch: | lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation |
| Merge into: | lp:ubuntu-calculator-app |
| Diff against target: |
23 lines (+2/-2) 2 files modified
app/ubuntu-calculator-app.qml (+1/-1) manifest.json.in (+1/-1) |
| To merge this branch: | bzr merge lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-01-14 | |
| Riccardo Padovani | Approve on 2015-01-14 | ||
| Alan Pope πΊπ§π± π¦ | 2015-01-14 | Approve on 2015-01-14 | |
|
Review via email:
|
|||
Commit Message
Fix keyboard layout switching on device rotation broken at rev #48. Hardcode architecture to 'all'.
Description of the Change
I broke the keyboard rotation on the mobile device on rev #48. My bad. Here's a fix for that bug :)
Now if the device is rotated the keyboard successfully switch to landscape mode.
Edit: as requested by @popey, the architecture in manifest.json is now hardcoded to "all", since there's no binary in our package.
Thanks,
Giulio
To post a comment you must log in.
lp:~gcollura/ubuntu-calculator-app/reboot-fix-keyboard-rotation
updated
on 2015-01-14
- 62. By Giulio Collura on 2015-01-14
-
hardcode architecture to 'all'
review:
Approve
(continuous-integration)


Fixed! Thanks! Tested on device.
http:// people. canonical. com/~alan/ screenshots/ device- 2015-01- 14-150931. png