Merge lp:~gaul/percona-xtrabackup/empty-password into lp:percona-xtrabackup/2.1

[Andrew Gaul]

[Alexey Kopytov (akopytov)]

Andrew,

My only concern is that this change will make _all_ options accept empty arguments, even if those where the argument is required.

It looks like the following change is what you actually want?

=== modified file 'innobackupex'
--- innobackupex 2012-06-18 12:32:21 +0000
+++ innobackupex 2012-08-03 10:29:11 +0000
@@ -1721,7 +1721,7 @@ sub check_args {
                         'use-memory=s' => \$option_use_memory,
                         'uncompress' => \$option_uncompress,
                         'export' => \$option_export,
- 'password=s' => \$option_mysql_password,
+ 'password:s' => \$option_mysql_password,
                         'user=s' => \$option_mysql_user,
                         'host=s' => \$option_mysql_host,
                         'port=s' => \$option_mysql_port,

review: Needs Information

[Andrew Gaul (gaul)]

I agree that your approach addresses my need more directly. I am unfamiliar with Perl and Getopt::Long and did not now about :s. Abandoning this commit.

[Alexey Kopytov (akopytov)]

Thanks for confirming, I have reported https://bugs.launchpad.net/percona-xtrabackup/+bug/1032667.

Feel free to resubmit the patch I suggested as a separate MP.

review: Needs Resubmitting

=== modified file 'innobackupex'
--- innobackupex	2012-06-18 14:00:00 +0000
+++ innobackupex	2012-08-03 00:08:20 +0000
@@ -7,7 +7,7 @@
 #
 
 use strict;
-use Getopt::Long;
+use Getopt::Long qw(:config gnu_compat);
 use File::Spec;
 use Pod::Usage qw(pod2usage);
 use POSIX "strftime";