Merge lp:~gary/launchpad/use-newer-revision into lp:launchpad/db-devel

[Gary Poster]

[Gary Poster (gary)]

This ups our revision of CIP to use Salgado's most recent change to that tree.

It's worrisome that tests did not fail without this.

[Guilherme Salgado (salgado)]

The existing c-i-p tests didn't fail because they only show (by loading pages using testbrowser) that nothing happens when the app is in read-only mode. However, they change the app to read-only by pushing a config overlay but don't actually show that it's enough to switch the app to read-only mode.

The new tests will fail if the switch to read-only mode doesn't succeed.

review: Approve (code)

[Guilherme Salgado (salgado)]

I wonder if we need similar changes to the lp-production-configs branch as well

[Gary Poster (gary)]

Thank you Salgado.

Yeah, it would be nice to upgrade lp-production-configs, but we have passing Launchpad test runs with CIP 8901, and no passing test runs yet with 8902. I'll upgrade the production configs to 8902 if we can get the error I sent you sorted out (and this landed before the buildbot freeze).

Gary

[Gary Poster (gary)]

I found a test failure when I ran this through ec2. Guilherme is going to (or has already started to) make a branch that diagnoses and fixes the failure.

Unmerged revisions

8933. By Gary Poster on 2010-01-26

we need to be using r8902 of CIP

=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf	2010-01-21 00:44:55 +0000
+++ utilities/sourcedeps.conf	2010-01-26 04:09:15 +0000
@@ -15,5 +15,5 @@
 subunit lp:~launchpad-pqm/subunit/trunk;revno=61
 subvertpy lp:~launchpad-pqm/subvertpy/trunk;revno=2040
 testresources lp:~launchpad-pqm/testresources/dev;revno=16
-canonical-identity-provider lp:~launchpad-pqm/canonical-identity-provider/trunk;revno=8901 optional
+canonical-identity-provider lp:~launchpad-pqm/canonical-identity-provider/trunk;revno=8902 optional
 shipit lp:~launchpad-pqm/shipit/trunk;revno=8901 optional