Merge lp:~gary/launchpad/owner_administrator into lp:launchpad
Proposed by
Gary Poster
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12902 |
Proposed branch: | lp:~gary/launchpad/owner_administrator |
Merge into: | lp:launchpad |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~gary/launchpad/owner_administrator |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+58683@code.launchpad.net |
Commit message
[r=benji][bug=768366] change the structural subscription overlay to not allow the current user to subscribe teams that they own but are not members of
Description of the change
This small branch changes the structural subscription overlay to not allow the current user to subscribe teams that they own but are not members of. An existing constraint that I'd rather not revisit right now is that only subscribers can modify their subscriptions. Allowing people to create a subscription but not edit it does not match our UI model. Therefore, I made this change.
lint is happy.
Thank you
To post a comment you must log in.
This branch looks good.
One little question: why do you sort team_info in lib/lp/ bugs/browser/ tests/test_ expose. py when you expect it to be empty?