Code review comment for lp:~gary/launchpad/bug164196-1

Revision history for this message
Данило Шеган (danilo) wrote :

<danilos> gary_poster, re -1, in lib/lp/bugs/model/ you modify addCommentNotification to add activity parameter, but you don't modify addChange which I believe does a similar thing for non-comment changes — is that intentional or not?
<gary_poster> danilos, intentional. addChange uses change objects, which handle activities themselves

review: Approve (code)

« Back to merge proposal